recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add a space after "View Inline" in mail to prevent double-click on the filename from selecting "Inline"

Summary:
See PHI920. Ref T13210. Since the HTML is just:

```
<a>View Inline</a><span>filename.txt</span>
```

..double-clicking "filename.txt" in email selects "Inlinefilename.txt".

Add a space to stop this. At least in Safari, a space between the tags is not sufficient (perhaps because the parent is a `<div>`?). I couldn't find an authoritative-seeming source on what the rules for this actually are and adding a space here fixes the issue without changing the visual rendering, so just put it here.

Test Plan:
- Made an inline.
- Used `bin/mail show-outbound --id ... --dump-html` to dump the HTML.
- Double-clicked the filename.

{F5929186}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13210

Differential Revision: https://secure.phabricator.com/D19742

epriestley 0a51bc4f 8bffc9ea

+12 -1
+12 -1
src/applications/differential/mail/DifferentialInlineCommentMailView.php
··· 446 446 'style' => implode(' ', $link_style), 447 447 'href' => $link_href, 448 448 ), 449 - pht('View Inline')); 449 + array( 450 + pht('View Inline'), 451 + 452 + // See PHI920. Add a space after the link so we render this into 453 + // the document: 454 + // 455 + // View Inline filename.txt 456 + // 457 + // Otherwise, we render "Inlinefilename.txt" and double-clicking 458 + // the file name selects the word "Inline" as well. 459 + ' ', 460 + )); 450 461 } else { 451 462 $link = null; 452 463 }