@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Purge readthrough caches before applying schema adjustments
Summary: Ref T1191. The bulk of the slowness in T1191 is copying tables. In some cases, we can't avoid this, but we have various readthrough caches which may be very large and are safe to drop, and dropping them is very quick (much less than 1 second). In particular, dropping the `changeset_parse_cache` made the process at least ~8 minutes faster on `secure.phabricator.com` (I killed it after 8 minutes, so I'm not sure what the real number is).
Test Plan: Ran `bin/storage adjust` and saw it drop caches before applying adjustments.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T1191
Differential Revision: https://secure.phabricator.com/D10616
+8
+8
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAdjustWorkflow.php
+8
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAdjustWorkflow.php
···
125
125
126
126
$console->writeOut(
127
127
"%s\n",
128
+
pht('Dropping caches, for faster migrations...'));
129
+
130
+
$root = dirname(phutil_get_library_root('phabricator'));
131
+
$bin = $root.'/bin/cache';
132
+
phutil_passthru('%s purge --purge-all', $bin);
133
+
134
+
$console->writeOut(
135
+
"%s\n",
128
136
pht('Fixing schema issues...'));
129
137
130
138
$api = $this->getAPI();