@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove property "id" from Workboard View controller
Summary: Depends on D20626. Ref T4900. On this controller, "id" is a separate property, but serves little purpose and complicates separating state management. Remove it.
Test Plan: Bulk edited a column, managed filters, did show/hide on columns, edited a column.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T4900
Differential Revision: https://secure.phabricator.com/D20627
+4
-6
+4
-6
src/applications/project/controller/PhabricatorProjectBoardViewController.php
+4
-6
src/applications/project/controller/PhabricatorProjectBoardViewController.php
···
5
5
6
6
const BATCH_EDIT_ALL = 'all';
7
7
8
-
private $id;
9
8
private $queryKey;
10
9
private $sortKey;
11
10
private $showHidden;
···
284
283
$query_key = $saved_query->getQueryKey();
285
284
286
285
$bulk_uri = new PhutilURI("/maniphest/bulk/query/{$query_key}/");
287
-
$bulk_uri->replaceQueryParam('board', $this->id);
286
+
$bulk_uri->replaceQueryParam('board', $project->getID());
288
287
289
288
return id(new AphrontRedirectResponse())
290
289
->setURI($bulk_uri);
···
781
780
$project = $this->getProject();
782
781
783
782
$this->showHidden = $request->getBool('hidden');
784
-
$this->id = $project->getID();
785
783
786
784
$sort_key = $this->getDefaultSort($project);
787
785
···
931
929
932
930
if ($is_custom) {
933
931
$uri = $this->getApplicationURI(
934
-
'board/'.$this->id.'/filter/query/'.$key.'/');
932
+
'board/'.$project->getID().'/filter/query/'.$key.'/');
935
933
$item->setWorkflow(true);
936
934
} else {
937
935
$uri = $engine->getQueryResultsPageURI($key);
···
1179
1177
->setIcon('fa-search')
1180
1178
->setHref($query_uri);
1181
1179
1182
-
$edit_uri = 'board/'.$this->id.'/edit/'.$column->getID().'/';
1180
+
$edit_uri = 'board/'.$project->getID().'/edit/'.$column->getID().'/';
1183
1181
$column_items[] = id(new PhabricatorActionView())
1184
1182
->setName(pht('Edit Column'))
1185
1183
->setIcon('fa-pencil')
···
1188
1186
->setWorkflow(true);
1189
1187
1190
1188
$can_hide = ($can_edit && !$column->isDefaultColumn());
1191
-
$hide_uri = 'board/'.$this->id.'/hide/'.$column->getID().'/';
1189
+
$hide_uri = 'board/'.$project->getID().'/hide/'.$column->getID().'/';
1192
1190
$hide_uri = $this->getApplicationURI($hide_uri);
1193
1191
$hide_uri = $this->getURIWithState($hide_uri);
1194
1192