recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove UI warnings about policies being a janky mess

Summary: Ref T603. While policies aren't completely perfect, they are substantially functional to the best of my knowledge -- definitely in good enough shape that we want to hear about issues with them, now.

Test Plan: Edited a task, repository, and project.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7343

epriestley 0b22777f 5171e368

-15
-5
src/applications/diffusion/controller/DiffusionRepositoryEditPolicyController.php
··· 71 71 72 72 $form = id(new AphrontFormView()) 73 73 ->setUser($viewer) 74 - ->appendRemarkupInstructions( 75 - pht( 76 - 'NOTE: The "Visible To" control is not yet fully functional. It '. 77 - 'applies to some interfaces, but some interfaces will bypass this '. 78 - 'setting and act as though it were set to "all users" for now.')) 79 74 ->appendChild( 80 75 id(new AphrontFormPolicyControl()) 81 76 ->setUser($viewer)
-4
src/applications/maniphest/controller/ManiphestTaskEditController.php
··· 471 471 ->setCapability(PhabricatorPolicyCapability::CAN_EDIT) 472 472 ->setPolicyObject($task) 473 473 ->setPolicies($policies) 474 - ->setCaption( 475 - pht( 476 - 'NOTE: These policy controls still have some rough edges and '. 477 - 'are not yet fully functional.')) 478 474 ->setName('editPolicy')) 479 475 ->appendChild( 480 476 id(new AphrontFormTokenizerControl())
-6
src/applications/project/controller/PhabricatorProjectProfileEditController.php
··· 131 131 ->setLabel(pht('Blurb')) 132 132 ->setName('blurb') 133 133 ->setValue($profile->getBlurb())) 134 - ->appendChild(hsprintf( 135 - '<p class="aphront-form-instructions">%s</p>', 136 - pht( 137 - 'NOTE: Policy settings are not yet fully implemented. '. 138 - 'Some interfaces still ignore these settings, '. 139 - 'particularly "Visible To".'))) 140 134 ->appendChild( 141 135 id(new AphrontFormPolicyControl()) 142 136 ->setUser($user)