@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Work around an issue with custom "users" fields in Maniphest
Summary:
Fixes T9558. The recent changes to validate PHID fields don't work cleanly with this gross hack.
This can probably be unwound now but it will definitely get fixed in T9132 so I may just wait for that.
Test Plan: Edited a custom "users" field in Maniphest. This should only affect Maniphest because it has a weird hack.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9558
Differential Revision: https://secure.phabricator.com/D14264
+2
-1
+2
-1
src/applications/maniphest/controller/ManiphestTaskEditController.php
+2
-1
src/applications/maniphest/controller/ManiphestTaskEditController.php
···
198
198
// in a meaningful way. For now, build User objects. Once the Maniphest
199
199
// objects exist, this will switch over automatically. This is a big
200
200
// hack but shouldn't be long for this world.
201
-
$placeholder_editor = new PhabricatorUserProfileEditor();
201
+
$placeholder_editor = id(new PhabricatorUserProfileEditor())
202
+
->setActor($viewer);
202
203
203
204
$field_errors = $aux_field->validateApplicationTransactions(
204
205
$placeholder_editor,