@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
PHPDoc: Replace non-existing return type markup with string
Summary: `markup` is not a valid type. See https://docs.phpdoc.org/guide/references/phpdoc/types.html and https://docs.phpdoc.org/guide/references/phpdoc/tags/return.html.
Test Plan: Read docs; run static code analysis.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D26064
+2
-2
+2
-2
src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
+2
-2
src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
···
495
495
* @param int $len Length of the line range to build links for.
496
496
* @param int $changeset_length Total number of lines in the changeset.
497
497
* @param bool $is_blocks (optional)
498
-
* @return markup Rendered links.
498
+
* @return string Rendered links.
499
499
*/
500
500
protected function renderShowContextLinks(
501
501
$top,
···
584
584
* @param bool $is_all Does this link show all context when clicked?
585
585
* @param string $range Range specification for lines to show.
586
586
* @param string $text Text of the link.
587
-
* @return markup Rendered link.
587
+
* @return string Rendered link.
588
588
*/
589
589
private function renderShowContextLink($is_all, $range, $text) {
590
590
$reference = $this->getRenderingReference();