@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix changeset loading issue for "Download Raw Diff" in Differential
Summary: Fixes T5309. Modernize this callsite to use ChangesetQuery and pick up attached objects.
Test Plan: Clicked "Download Raw Diff" in Differential.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T5309
Differential Revision: https://secure.phabricator.com/D9461
+6
-7
+6
-7
src/applications/differential/controller/DifferentialRevisionViewController.php
+6
-7
src/applications/differential/controller/DifferentialRevisionViewController.php
···
673
673
DifferentialDiff $diff_vs = null,
674
674
PhabricatorRepository $repository = null) {
675
675
676
-
$load_ids = array();
676
+
$load_diffs = array($target);
677
677
if ($diff_vs) {
678
-
$load_ids[] = $diff_vs->getID();
678
+
$load_diffs[] = $diff_vs;
679
679
}
680
-
$load_ids[] = $target->getID();
681
680
682
-
$raw_changesets = id(new DifferentialChangeset())
683
-
->loadAllWhere(
684
-
'diffID IN (%Ld)',
685
-
$load_ids);
681
+
$raw_changesets = id(new DifferentialChangesetQuery())
682
+
->setViewer($this->getRequest()->getUser())
683
+
->withDiffs($load_diffs)
684
+
->execute();
686
685
$changeset_groups = mgroup($raw_changesets, 'getDiffID');
687
686
688
687
$changesets = idx($changeset_groups, $target->getID(), array());