@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Log Herald rules with invalid actions via phlog()
Summary:
When Herald rules fail unexpectedly due to relying on a (now) invalid action, allow Phorge administrators to get aware by creating an entry in the error log via `phlog()` instead of crossing fingers that someone may from time to time get the idea to open and read Herald transcripts.
Refs T15887
Test Plan: See steps in T15887; check error log.
Reviewers: O1 Blessed Committers, avivey
Reviewed By: O1 Blessed Committers, avivey
Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15887
Differential Revision: https://we.phorge.it/D25737
+8
+8
src/applications/herald/engine/HeraldEngine.php
+8
src/applications/herald/engine/HeraldEngine.php
···
688
688
->setTarget($action->getTarget())
689
689
->setRule($rule);
690
690
691
+
if ($object->getActionImplementation($action->getAction()) === null) {
692
+
phlog(pht('An exception occurred executing Herald rule %s: Unknown '.
693
+
'action: "%s". Review the Herald transcripts and correct or '.
694
+
'disable the problematic rule.',
695
+
$rule->getMonogram(),
696
+
$action->getAction()));
697
+
}
698
+
691
699
$name = $rule->getName();
692
700
$id = $rule->getID();
693
701
$effect->setReason(