@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up NUX a bit on Diffusion
Summary: Just some cleanup. Make sure action-bar has consistent space if locate is there or not, hide tabs if repository has no content. Use clone or checkout language depending on SCM. Fixes T12915.
Test Plan:
Test git, hg, svn blank states.
{F5042707}
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T12915
Differential Revision: https://secure.phabricator.com/D18208
+20
-6
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
75
75
'rsrc/css/application/diffusion/diffusion-readme.css' => '419dd5b6',
76
76
'rsrc/css/application/diffusion/diffusion-repository.css' => 'ee6f20ec',
77
77
'rsrc/css/application/diffusion/diffusion-source.css' => '750add59',
78
-
'rsrc/css/application/diffusion/diffusion.css' => '08991f7e',
78
+
'rsrc/css/application/diffusion/diffusion.css' => '8d01932f',
79
79
'rsrc/css/application/feed/feed.css' => 'ecd4ec57',
80
80
'rsrc/css/application/files/global-drag-and-drop.css' => '5c1b47c2',
81
81
'rsrc/css/application/flag/flag.css' => 'bba8f811',
···
571
571
'differential-revision-history-css' => '0e8eb855',
572
572
'differential-revision-list-css' => 'f3c47d33',
573
573
'differential-table-of-contents-css' => 'ae4b7a55',
574
-
'diffusion-css' => '08991f7e',
574
+
'diffusion-css' => '8d01932f',
575
575
'diffusion-icons-css' => '0c15255e',
576
576
'diffusion-readme-css' => '419dd5b6',
577
577
'diffusion-repository-css' => 'ee6f20ec',
+13
-3
src/applications/diffusion/controller/DiffusionRepositoryController.php
+13
-3
src/applications/diffusion/controller/DiffusionRepositoryController.php
···
94
94
'action' => 'clone',
95
95
));
96
96
97
+
if ($repository->isSVN()) {
98
+
$clone_text = pht('Checkout');
99
+
} else {
100
+
$clone_text = pht('Clone');
101
+
}
102
+
97
103
$clone_button = id(new PHUIButtonView())
98
104
->setTag('a')
99
-
->setText('Clone')
105
+
->setText($clone_text)
100
106
->setColor(PHUIButtonView::GREEN)
101
107
->setIcon('fa-download')
102
108
->setWorkflow(true)
···
104
110
105
111
$bar = id(new PHUILeftRightView())
106
112
->setLeft($locate_file)
107
-
->setRight($clone_button);
113
+
->setRight($clone_button)
114
+
->addClass('diffusion-action-bar');
108
115
109
116
$view = id(new PHUITwoColumnView())
110
117
->setHeader($header)
111
-
->setTabs($tabs)
112
118
->setFooter(array(
113
119
$bar,
114
120
$description,
115
121
$content,
116
122
));
123
+
124
+
if ($page_has_content) {
125
+
$view->setTabs($tabs);
126
+
}
117
127
118
128
return $this->newPage()
119
129
->setTitle(