recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

a11y: Set textarea name parameter also as aria-label

Summary:
Form elements should have associated labels per https://www.w3.org/WAI/tutorials/forms/labels/
Setting the `name` parameter for a `<textarea>` also as its `aria-label` is clearly more accessible than exposing no hints at all.

Ref T16072

Test Plan:
Go to http://phorge.localhost/D1, inspect comment field (below "Add Action..." dropdown) markup, see additional `aria-label="comment"` for `<textarea>`
Go to http://phorge.localhost/T1, inspect comment field (below "Add Action..." dropdown) markup, see additional `aria-label="comment"` for `<textarea>`
Go to http://phorge.localhost/maniphest/task/edit/1/, inspect Description field markup, see additional `aria-label="description"` for `<textarea>`
Go to http://phorge.localhost/paste/edit/1/, inspect Text field markup, see additional `aria-label="text"` for `<textarea>`
Optionally, run an Accessibility check in Chromium Lighthouse.

Reviewers: O1 Blessed Committers, chris

Reviewed By: O1 Blessed Committers, chris

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16072

Differential Revision: https://we.phorge.it/D26045

Andre Klapper 0c65f2d3 ff2ac047

+1
+1
src/view/form/control/AphrontFormTextAreaControl.php
··· 84 84 'textarea', 85 85 array( 86 86 'name' => $this->getName(), 87 + 'aria-label' => $this->getName(), 87 88 'disabled' => $this->getDisabled() ? 'disabled' : null, 88 89 'readonly' => $this->getReadOnly() ? 'readonly' : null, 89 90 'class' => $classes,