@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Herald - make flag color display
Summary: It used to say "Mark with flag 7" or whatever, and now it says "Mark with flag Checkered"
Test Plan: noted previous rule I made was more understandable
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Differential Revision: https://secure.phabricator.com/D8158
+10
-3
+10
-3
src/applications/herald/adapter/HeraldAdapter.php
+10
-3
src/applications/herald/adapter/HeraldAdapter.php
···
1013
1013
$target = array($target);
1014
1014
}
1015
1015
foreach ($target as $index => $val) {
1016
-
$handle = idx($handles, $val);
1017
-
if ($handle) {
1018
-
$target[$index] = $handle->renderLink();
1016
+
switch ($action->getAction()) {
1017
+
case self::ACTION_FLAG:
1018
+
$target[$index] = PhabricatorFlagColor::getColorName($val);
1019
+
break;
1020
+
default:
1021
+
$handle = idx($handles, $val);
1022
+
if ($handle) {
1023
+
$target[$index] = $handle->renderLink();
1024
+
}
1025
+
break;
1019
1026
}
1020
1027
}
1021
1028
$target = phutil_implode_html(', ', $target);