@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make Herald have "exists" and "not exists" options for differential reviewers on commit rules
Summary: Fixes T1485.
Test Plan: made a herald rule for "not exists". committed to master with no diff. audit was triggered
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, aran
Maniphest Tasks: T1485
Differential Revision: https://secure.phabricator.com/D6964
+7
+7
src/applications/herald/adapter/HeraldCommitAdapter.php
+7
src/applications/herald/adapter/HeraldCommitAdapter.php
···
71
71
public function getConditionsForField($field) {
72
72
switch ($field) {
73
73
case self::FIELD_DIFFERENTIAL_REVIEWERS:
74
+
return array(
75
+
self::CONDITION_EXISTS,
76
+
self::CONDITION_NOT_EXISTS,
77
+
self::CONDITION_INCLUDE_ALL,
78
+
self::CONDITION_INCLUDE_ANY,
79
+
self::CONDITION_INCLUDE_NONE,
80
+
);
74
81
case self::FIELD_DIFFERENTIAL_CCS:
75
82
return array(
76
83
self::CONDITION_INCLUDE_ALL,