recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Partially revert D14511 to fix "INLINE COMMENTS" in mail

Summary:
Ref T9845. In Differential, this is not a remarkup block -- it's a mail section. `addTextSection()` has special magic behavior when handed a prebuilt section since D9375.

Swapping to `addRemarkupSection()` causes the error in T9845 and renders nothing in the comment section.

Even if it were a block of text, it would not be appropriate to add it as remarkup. This would incorrectly render comments in files like `__init__.py`, which are common on Python (the filename would render as "__init__.py"). Okay that's a bad example since it works fine but, uh, a file named `T123` would be no good or whatever.

I'll realign T9845 to clean this up and fix it more durably.

Test Plan: Sent myself some mail with inline comments, saw them in the mail.

Reviewers: joshuaspence, chad

Reviewed By: chad

Maniphest Tasks: T9845

Differential Revision: https://secure.phabricator.com/D14589

epriestley 0d01dab5 5eada3d8

+2 -2
+1 -1
src/applications/audit/editor/PhabricatorAuditEditor.php
··· 660 660 } 661 661 662 662 if ($inlines) { 663 - $body->addRemarkupSection( 663 + $body->addTextSection( 664 664 pht('INLINE COMMENTS'), 665 665 $this->renderInlineCommentsForMail($object, $inlines)); 666 666 }
+1 -1
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 1212 1212 } 1213 1213 1214 1214 if ($inlines) { 1215 - $body->addRemarkupSection( 1215 + $body->addTextSection( 1216 1216 pht('INLINE COMMENTS'), 1217 1217 $this->renderInlineCommentsForMail($object, $inlines)); 1218 1218 }