recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page

Summary:
Passing null as an input string to explode() is deprecated in PHP 8.
Thus first check via `phutil_nonempty_string()` that the input string is not null.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15361

Test Plan: Applied this change; afterwards `/multimeter/` correctly rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15361

Differential Revision: https://we.phorge.it/D25254

Andre Klapper 0d81da59 827f63a0

+1 -1
+1 -1
src/applications/multimeter/controller/MultimeterSampleController.php
··· 10 10 $viewer = $this->getViewer(); 11 11 $group_map = $this->getColumnMap(); 12 12 13 - $group = explode('.', $request->getStr('group')); 13 + $group = explode('.', $request->getStr('group', '')); 14 14 $group = array_intersect($group, array_keys($group_map)); 15 15 $group = array_fuse($group); 16 16