recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

In ApplicationTransactionEditor, determine new objects with "getID()" instead of "getPHID()"

Summary:
See <https://discourse.phabricator-community.org/t/unable-to-reload-object-that-hasnt-been-loaded/2677>.

When editing "Config" objects, they currently get a PHID set outside of the TransactionEditor. They probably should not, but fixing that is likely an involved change.

This causes us to incorrectly fail to detect `$is_new` correctly and try to `reload()` and object with no ID.

To work around this, test for new objects with `getID()` instead of `getPHID()`.

Test Plan: Edited any config value with the web UI.

Reviewers: amckinley

Differential Revision: https://secure.phabricator.com/D20482

epriestley 0d936235 c0a4d1de

+1 -1
+1 -1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
··· 977 977 PhabricatorLiskDAO $object, 978 978 array $xactions) { 979 979 980 - $is_new = ($object->getPHID() === null); 980 + $is_new = ($object->getID() === null); 981 981 $this->isNewObject = $is_new; 982 982 983 983 $is_preview = $this->getIsPreview();