@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remarkup - call pasted files "pasted_file" rather than "undefined"

Summary: Fixes T5917. Turns out that pasted files don't get a name - "what is data on a clipboard anyway?" / see https://code.google.com/p/chromium/issues/detail?id=361145

Test Plan: pasted a file and got the slightly better name "pasted_file"

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5917

Differential Revision: https://secure.phabricator.com/D10310

+18 -12
+11 -11
resources/celerity/map.php
··· 11 11 'core.pkg.js' => 'f67c8265', 12 12 'darkconsole.pkg.js' => 'df001cab', 13 13 'differential.pkg.css' => '36884139', 14 - 'differential.pkg.js' => 'eb182ccd', 14 + 'differential.pkg.js' => 'fe026527', 15 15 'diffusion.pkg.css' => '591664fa', 16 16 'diffusion.pkg.js' => 'bfc0737b', 17 17 'maniphest.pkg.css' => 'f5d89daf', ··· 437 437 'rsrc/js/application/uiexample/gesture-example.js' => '558829c2', 438 438 'rsrc/js/application/uiexample/notification-example.js' => '7a9677fc', 439 439 'rsrc/js/core/Busy.js' => '6453c869', 440 - 'rsrc/js/core/DragAndDropFileUpload.js' => 'f61aa8ec', 440 + 'rsrc/js/core/DragAndDropFileUpload.js' => '8c49f386', 441 441 'rsrc/js/core/DraggableList.js' => 'bfccc644', 442 442 'rsrc/js/core/FileUpload.js' => 'a4ae61bf', 443 443 'rsrc/js/core/Hovercard.js' => '7e8468ae', ··· 712 712 'phabricator-countdown-css' => '86b7b0a0', 713 713 'phabricator-crumbs-view-css' => '7fbf25b8', 714 714 'phabricator-dashboard-css' => 'a2bfdcbf', 715 - 'phabricator-drag-and-drop-file-upload' => 'f61aa8ec', 715 + 'phabricator-drag-and-drop-file-upload' => '8c49f386', 716 716 'phabricator-draggable-list' => 'bfccc644', 717 717 'phabricator-fatal-config-template-css' => '25d446d6', 718 718 'phabricator-feed-css' => '4e544db4', ··· 1385 1385 'javelin-request', 1386 1386 'javelin-typeahead-source', 1387 1387 ), 1388 + '8c49f386' => array( 1389 + 'javelin-install', 1390 + 'javelin-util', 1391 + 'javelin-request', 1392 + 'javelin-dom', 1393 + 'javelin-uri', 1394 + 'phabricator-file-upload', 1395 + ), 1388 1396 '8d199d97' => array( 1389 1397 'javelin-behavior', 1390 1398 'javelin-dom', ··· 1866 1874 'phabricator-prefab', 1867 1875 'multirow-row-manager', 1868 1876 'javelin-json', 1869 - ), 1870 - 'f61aa8ec' => array( 1871 - 'javelin-install', 1872 - 'javelin-util', 1873 - 'javelin-request', 1874 - 'javelin-dom', 1875 - 'javelin-uri', 1876 - 'phabricator-file-upload', 1877 1877 ), 1878 1878 'f6555212' => array( 1879 1879 'javelin-install',
+7 -1
webroot/rsrc/js/core/DragAndDropFileUpload.js
··· 158 158 if (!/^image\//.test(item.type)) { 159 159 continue; 160 160 } 161 - this._sendRequest(item.getAsFile()); 161 + var spec = item.getAsFile(); 162 + // pasted files don't have a name; see 163 + // https://code.google.com/p/chromium/issues/detail?id=361145 164 + if (!spec.name) { 165 + spec.name = 'pasted_file'; 166 + } 167 + this._sendRequest(spec); 162 168 } 163 169 })); 164 170 }