recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button

Summary:
Ref T13330. Handles for "OAuthServerClient" objects currently do not have a URI, which causes some obscure fallout like a missing "Close" button when examining their transactions.

Add a URI.

Test Plan:
- Viewed an OAuth server client detail page.
- Edited a policy, changing it to a custom policy.
- Clicked "Custom Policy" in the resulting transaction to view a dialog explaining the changes.
- Before change: dialog has no close button.
- After change: dialog has a close button.

{F6534121}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13330

Differential Revision: https://secure.phabricator.com/D20624

epriestley 0e2cb6e7 d6dc5d8e

+9 -1
+3 -1
src/applications/oauthserver/phid/PhabricatorOAuthServerClientPHIDType.php
··· 32 32 foreach ($handles as $phid => $handle) { 33 33 $client = $objects[$phid]; 34 34 35 - $handle->setName($client->getName()); 35 + $handle 36 + ->setName($client->getName()) 37 + ->setURI($client->getURI()); 36 38 } 37 39 } 38 40
+6
src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php
··· 59 59 PhabricatorOAuthServerClientPHIDType::TYPECONST); 60 60 } 61 61 62 + public function getURI() { 63 + return urisprintf( 64 + '/oauthserver/client/view/%d/', 65 + $this->getID()); 66 + } 67 + 62 68 63 69 /* -( PhabricatorPolicyInterface )----------------------------------------- */ 64 70