@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Support placeholder text in Herald
Summary: Ref T4420. We don't currently pass placeholder text properly, but should.
Test Plan: Saw placeholder text in Herald.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T4420
Differential Revision: https://secure.phabricator.com/D9901
+19
-13
+11
-11
resources/celerity/map.php
+11
-11
resources/celerity/map.php
···
392
392
'rsrc/js/application/files/behavior-icon-composer.js' => '8ef9ab58',
393
393
'rsrc/js/application/files/behavior-launch-icon-composer.js' => '48086888',
394
394
'rsrc/js/application/harbormaster/behavior-reorder-steps.js' => 'b716477f',
395
-
'rsrc/js/application/herald/HeraldRuleEditor.js' => '58e048fc',
395
+
'rsrc/js/application/herald/HeraldRuleEditor.js' => '3fc2c8f2',
396
396
'rsrc/js/application/herald/PathTypeahead.js' => 'f7fc67ec',
397
397
'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3',
398
398
'rsrc/js/application/maniphest/behavior-batch-editor.js' => 'f588412e',
···
543
543
'global-drag-and-drop-css' => '697324ad',
544
544
'harbormaster-css' => 'cec833b7',
545
545
'herald-css' => 'c544dd1c',
546
-
'herald-rule-editor' => '58e048fc',
546
+
'herald-rule-editor' => '3fc2c8f2',
547
547
'herald-test-css' => '778b008e',
548
548
'inline-comment-summary-css' => '8cfd34e8',
549
549
'javelin-aphlict' => '4a07e8e3',
···
1103
1103
2 => 'javelin-stratcom',
1104
1104
3 => 'phabricator-tooltip',
1105
1105
),
1106
+
'3fc2c8f2' => array(
1107
+
0 => 'multirow-row-manager',
1108
+
1 => 'javelin-install',
1109
+
2 => 'javelin-util',
1110
+
3 => 'javelin-dom',
1111
+
4 => 'javelin-stratcom',
1112
+
5 => 'javelin-json',
1113
+
6 => 'phabricator-prefab',
1114
+
),
1106
1115
'40a6a403' => array(
1107
1116
0 => 'javelin-install',
1108
1117
1 => 'javelin-dom',
···
1198
1207
1 => 'javelin-behavior',
1199
1208
2 => 'javelin-vector',
1200
1209
3 => 'javelin-dom',
1201
-
),
1202
-
'58e048fc' => array(
1203
-
0 => 'multirow-row-manager',
1204
-
1 => 'javelin-install',
1205
-
2 => 'javelin-util',
1206
-
3 => 'javelin-dom',
1207
-
4 => 'javelin-stratcom',
1208
-
5 => 'javelin-json',
1209
-
6 => 'phabricator-prefab',
1210
1210
),
1211
1211
'58f7803f' => array(
1212
1212
0 => 'javelin-behavior',
+6
-1
src/applications/herald/controller/HeraldRuleController.php
+6
-1
src/applications/herald/controller/HeraldRuleController.php
···
601
601
'userorproject' => new PhabricatorProjectOrUserDatasource(),
602
602
);
603
603
604
-
$sources = mpull($sources, 'getDatasourceURI');
604
+
foreach ($sources as $key => $source) {
605
+
$sources[$key] = array(
606
+
'uri' => $source->getDatasourceURI(),
607
+
'placeholder' => $source->getPlaceholderText(),
608
+
);
609
+
}
605
610
606
611
return array(
607
612
'source' => $sources,
+2
-1
webroot/rsrc/js/application/herald/HeraldRuleEditor.js
+2
-1
webroot/rsrc/js/application/herald/HeraldRuleEditor.js
···
283
283
284
284
var tokenizerConfig = {
285
285
root : template,
286
-
src : this._config.template.source[type],
286
+
src : this._config.template.source[type].uri,
287
+
placeholder: this._config.template.source[type].placeholder,
287
288
icons : this._config.template.icons,
288
289
username : this._config.username
289
290
};