recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove "dateCommitted" field from DifferentialRevision

Summary: Ref T2222. This is obsolete and no longer used. We could deduce it from transactions or commits in modern Phabricator if we wanted it. We may implement a more general mechanism for T4434.

Test Plan: `grep`

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8330

epriestley 0f0673b9 9292433d

+2 -13
+2
resources/sql/autopatches/20140224.dxclean.1.datecommitted.sql
··· 1 + ALTER TABLE {$NAMESPACE}_differential.differential_revision 2 + DROP dateCommitted;
-1
src/applications/differential/conduit/ConduitAPI_differential_close_Method.php
··· 60 60 $editor->save(); 61 61 62 62 $revision->setStatus(ArcanistDifferentialRevisionStatus::CLOSED); 63 - $revision->setDateCommitted(time()); 64 63 $revision->save(); 65 64 66 65 return;
-4
src/applications/differential/editor/DifferentialCommentEditor.php
··· 409 409 } 410 410 } 411 411 412 - if (!$revision->getDateCommitted()) { 413 - $revision->setDateCommitted(time()); 414 - } 415 - 416 412 $revision->setStatus(ArcanistDifferentialRevisionStatus::CLOSED); 417 413 break; 418 414
-5
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 143 143 // TODO: Update review status? 144 144 break; 145 145 case DifferentialAction::ACTION_CLOSE: 146 - if (!$object->getDateCommitted()) { 147 - // TODO: Can we remove this? It is probably no longer used by 148 - // anything anymore. See also T4434. 149 - $object->setDateCommitted(time()); 150 - } 151 146 $object->setStatus(ArcanistDifferentialRevisionStatus::CLOSED); 152 147 break; 153 148 default:
-2
src/applications/differential/storage/DifferentialRevision.php
··· 20 20 protected $authorPHID; 21 21 protected $lastReviewerPHID; 22 22 23 - protected $dateCommitted; 24 - 25 23 protected $lineCount = 0; 26 24 protected $attached = array(); 27 25
-1
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
··· 117 117 118 118 $diff = $this->attachToRevision($revision, $actor_phid); 119 119 120 - $revision->setDateCommitted($commit->getEpoch()); 121 120 $editor = new DifferentialCommentEditor( 122 121 $revision, 123 122 DifferentialAction::ACTION_CLOSE);