@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
In Phabricator, drop PhutilClassMap caches after loading additional libraries
Summary:
Depends on D16755. Right now, we build a setup check map (to run preflight checks), then later load libraries.
This means any checks included in third-party libraries don't get added to the map, and no longer run.
(These are rare, but Phacility has a couple).
Instead, delete the caches after loading extra libraries.
Test Plan: With this and D16755, re-ran setup checks and saw Phacility setup checks run.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D16756
+6
+6
src/infrastructure/env/PhabricatorEnv.php
+6
src/infrastructure/env/PhabricatorEnv.php
···
202
202
phutil_load_library($library);
203
203
}
204
204
205
+
// Drop any class map caches, since they will have generated without
206
+
// any classes from libraries. Without this, preflight setup checks can
207
+
// cause generation of a setup check cache that omits checks defined in
208
+
// libraries, for example.
209
+
PhutilClassMapQuery::deleteCaches();
210
+
205
211
// If custom libraries specify config options, they won't get default
206
212
// values as the Default source has already been loaded, so we get it to
207
213
// pull in all options from non-phabricator libraries now they are loaded.