@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Policy Header rollout
Summary: Adds policy headers to more (all?) places currently in use.
Test Plan: test each page changed.
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, aran
Differential Revision: https://secure.phabricator.com/D7032
+42
-36
+10
-5
src/applications/diviner/controller/DivinerBookController.php
+10
-5
src/applications/diviner/controller/DivinerBookController.php
···
32
32
->setName($book->getShortTitle())
33
33
->setHref('/book/'.$book->getName().'/'));
34
34
35
-
$header = id(new PHUIHeaderView())->setHeader($book->getTitle());
35
+
$policies = PhabricatorPolicyQuery::renderPolicyDescriptions(
36
+
$viewer,
37
+
$book,
38
+
true);
39
+
40
+
$header = id(new PHUIHeaderView())
41
+
->setHeader($book->getTitle())
42
+
->addProperty(PHUIHeaderView::PROPERTY_POLICY,
43
+
$policies[PhabricatorPolicyCapability::CAN_VIEW]);
44
+
36
45
$document = new PHUIDocumentView();
37
46
$document->setHeader($header);
38
47
···
87
96
$policies = PhabricatorPolicyQuery::renderPolicyDescriptions(
88
97
$user,
89
98
$book);
90
-
91
-
$view->addProperty(
92
-
pht('Visible To'),
93
-
$policies[PhabricatorPolicyCapability::CAN_VIEW]);
94
99
95
100
$view->addProperty(
96
101
pht('Updated'),
+8
-5
src/applications/phame/controller/blog/PhameBlogViewController.php
+8
-5
src/applications/phame/controller/blog/PhameBlogViewController.php
···
33
33
34
34
$nav = $this->renderSideNavFilterView(null);
35
35
36
+
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
37
+
$user,
38
+
$blog,
39
+
true);
40
+
36
41
$header = id(new PHUIHeaderView())
37
-
->setHeader($blog->getName());
42
+
->setHeader($blog->getName())
43
+
->addProperty(PHUIHeaderView::PROPERTY_POLICY,
44
+
$descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
38
45
39
46
$handle_phids = array_merge(
40
47
mpull($posts, 'getBloggerPHID'),
···
110
117
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
111
118
$user,
112
119
$blog);
113
-
114
-
$properties->addProperty(
115
-
pht('Visible To'),
116
-
$descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
117
120
118
121
$properties->addProperty(
119
122
pht('Editable By'),
+8
-9
src/applications/phame/controller/post/PhamePostViewController.php
+8
-9
src/applications/phame/controller/post/PhamePostViewController.php
···
34
34
$actions = $this->renderActions($post, $user);
35
35
$properties = $this->renderProperties($post, $user);
36
36
37
+
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
38
+
$user,
39
+
$post,
40
+
true);
41
+
37
42
$crumbs = $this->buildApplicationCrumbs();
38
43
$crumbs->setActionList($actions);
39
44
$crumbs->addCrumb(
···
44
49
$nav->appendChild($crumbs);
45
50
$nav->appendChild(
46
51
id(new PHUIHeaderView())
47
-
->setHeader($post->getTitle()));
52
+
->setHeader($post->getTitle())
53
+
->addProperty(PHUIHeaderView::PROPERTY_POLICY,
54
+
$descriptions[PhabricatorPolicyCapability::CAN_VIEW]));
48
55
49
56
if ($post->isDraft()) {
50
57
$nav->appendChild(
···
167
174
->setUser($user)
168
175
->setObject($post);
169
176
170
-
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
171
-
$user,
172
-
$post);
173
-
174
177
$properties->addProperty(
175
178
pht('Blog'),
176
179
$post->getBlogPHID()
···
180
183
$properties->addProperty(
181
184
pht('Blogger'),
182
185
$this->getHandle($post->getBloggerPHID())->renderLink());
183
-
184
-
$properties->addProperty(
185
-
pht('Visible To'),
186
-
$descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
187
186
188
187
$properties->addProperty(
189
188
pht('Published'),
+8
-8
src/applications/phlux/controller/PhluxViewController.php
+8
-8
src/applications/phlux/controller/PhluxViewController.php
···
30
30
->setName($title)
31
31
->setHref($request->getRequestURI()));
32
32
33
+
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
34
+
$user,
35
+
$var,
36
+
true);
37
+
33
38
$header = id(new PHUIHeaderView())
34
-
->setHeader($title);
39
+
->setHeader($title)
40
+
->addProperty(PHUIHeaderView::PROPERTY_POLICY,
41
+
$descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
35
42
36
43
$actions = id(new PhabricatorActionListView())
37
44
->setUser($user)
···
53
60
54
61
$display_value = json_encode($var->getVariableValue());
55
62
56
-
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
57
-
$user,
58
-
$var);
59
-
60
63
$properties = id(new PhabricatorPropertyListView())
61
64
->setUser($user)
62
65
->setObject($var)
63
66
->addProperty(pht('Value'), $display_value)
64
-
->addProperty(
65
-
pht('Visible To'),
66
-
$descriptions[PhabricatorPolicyCapability::CAN_VIEW])
67
67
->addProperty(
68
68
pht('Editable By'),
69
69
$descriptions[PhabricatorPolicyCapability::CAN_EDIT]);
+8
-9
src/applications/slowvote/controller/PhabricatorSlowvotePollController.php
+8
-9
src/applications/slowvote/controller/PhabricatorSlowvotePollController.php
···
41
41
));
42
42
}
43
43
44
+
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
45
+
$user,
46
+
$poll,
47
+
true);
48
+
44
49
$header = id(new PHUIHeaderView())
45
-
->setHeader($poll->getQuestion());
50
+
->setHeader($poll->getQuestion())
51
+
->addProperty(PHUIHeaderView::PROPERTY_POLICY,
52
+
$descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
46
53
47
54
$xaction_header = id(new PHUIHeaderView())
48
55
->setHeader(pht('Ongoing Deliberations'));
···
110
117
$view = id(new PhabricatorPropertyListView())
111
118
->setUser($viewer)
112
119
->setObject($poll);
113
-
114
-
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
115
-
$viewer,
116
-
$poll);
117
-
118
-
$view->addProperty(
119
-
pht('Visible To'),
120
-
$descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
121
120
122
121
$view->invokeWillRenderEvent();
123
122