@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Set an explicit default value for the bulk action control
Summary:
Ref T13025. See <https://discourse.phabricator-community.org/t/bulk-edit-no-actions-available/1011/1>.
I'm not sure if this is what the user is seeing, but in Chrome, the `<select />` does not automatically get set to the first valid value like it does in Safari.
Set it to the first valid value explicitly.
Test Plan: In Chrome, bulk editor previously hit a JS error when trying to read a bad action off the `<select />`. After patch, bulk edits go through cleanly.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13025
Differential Revision: https://secure.phabricator.com/D18923
+6
+6
src/applications/transactions/bulk/PhabricatorBulkEngine.php
+6
src/applications/transactions/bulk/PhabricatorBulkEngine.php
···
303
303
304
304
$spec = array();
305
305
$option_groups = igroup($edit_map, 'group');
306
+
$default_value = null;
306
307
foreach ($groups as $group_key => $group) {
307
308
$options = idx($option_groups, $group_key, array());
308
309
if (!$options) {
···
315
316
'key' => $option['xaction'],
316
317
'label' => $option['label'],
317
318
);
319
+
320
+
if ($default_value === null) {
321
+
$default_value = $option['xaction'];
322
+
}
318
323
}
319
324
320
325
$spec[] = array(
···
332
337
'inputNodeID' => $input_id,
333
338
'edits' => $edit_map,
334
339
'optgroups' => array(
340
+
'value' => $default_value,
335
341
'groups' => $spec,
336
342
),
337
343
));