recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue where subpriority paging could be truncated

Ref T7548. Subpriority is a float, but we're truncating it to an int, which can cause reselection of the same row while paging.

epriestley 106ca70a 77e0a4ab

+5 -2
+2 -2
src/applications/maniphest/query/ManiphestTaskQuery.php
··· 1066 1066 } 1067 1067 $columns[] = array( 1068 1068 'name' => 'task.subpriority', 1069 - 'value' => (int)$cursor->getSubpriority(), 1070 - 'type' => 'int', 1069 + 'value' => $cursor->getSubpriority(), 1070 + 'type' => 'float', 1071 1071 'reverse' => true, 1072 1072 ); 1073 1073 $columns[] = array(
+3
src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
··· 252 252 case 'int': 253 253 $value = qsprintf($conn, '%d', $column['value']); 254 254 break; 255 + case 'float': 256 + $value = qsprintf($conn, '%f', $column['value']); 257 + break; 255 258 case 'string': 256 259 $value = qsprintf($conn, '%s', $column['value']); 257 260 break;