recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix handling of "null" domain values in Charts

Summary: Depends on D20487. If you `min(1, 2, null)`, you get `null`. We want `1`.

Test Plan: Viewed a "burnup for project X" chart where one dataseries had no datapoints. Saw a sensible domain selected automatically.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: yelirekim

Differential Revision: https://secure.phabricator.com/D20488

epriestley 10afe1f2 146317f2

+6 -2
+6 -2
src/applications/fact/chart/PhabricatorHigherOrderChartFunction.php
··· 10 10 $domain = $function->getDomain(); 11 11 if ($domain !== null) { 12 12 list($min, $max) = $domain; 13 - $minv[] = $min; 14 - $maxv[] = $max; 13 + if ($min !== null) { 14 + $minv[] = $min; 15 + } 16 + if ($max !== null) { 17 + $maxv[] = $max; 18 + } 15 19 } 16 20 } 17 21