@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Stop Phriction handling it's own Subscribers
Summary: Stop Phriction displaying subscribers twice.
Test Plan:
Add Subscriber, remove subscriber, make sure I see only one subscribers list.
Fixes T3534
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T3534
Differential Revision: https://secure.phabricator.com/D6457
authored by
Gareth Evans
and committed by
epriestley
10c9e387
d6ce5a31
+2
-14
+2
-14
src/applications/phriction/controller/PhrictionDocumentController.php
+2
-14
src/applications/phriction/controller/PhrictionDocumentController.php
···
85
85
}
86
86
$page_title = $content->getTitle();
87
87
88
-
$subscribers = PhabricatorSubscribersQuery::loadSubscribersForPHID(
89
-
$document->getPHID());
90
88
$properties = $this
91
-
->buildPropertyListView($document, $content, $slug, $subscribers);
89
+
->buildPropertyListView($document, $content, $slug);
92
90
93
91
$doc_status = $document->getStatus();
94
92
$current_status = $content->getChangeType();
···
201
199
private function buildPropertyListView(
202
200
PhrictionDocument $document,
203
201
PhrictionContent $content,
204
-
$slug,
205
-
array $subscribers) {
202
+
$slug) {
206
203
207
204
$viewer = $this->getRequest()->getUser();
208
205
$view = id(new PhabricatorPropertyListView())
···
225
222
$project_phid,
226
223
));
227
224
228
-
if ($subscribers) {
229
-
$phids = array_merge($phids, $subscribers);
230
-
}
231
-
232
225
$this->loadHandles($phids);
233
226
234
227
$project_info = null;
···
252
245
$when = pht("%d Days Ago", $age);
253
246
}
254
247
$view->addProperty(pht('Last Updated'), $when);
255
-
256
-
if ($subscribers) {
257
-
$subscribers = $this->renderHandlesForPHIDs($subscribers, ',');
258
-
$view->addProperty(pht('Subscribers'), $subscribers);
259
-
}
260
248
261
249
return $view;
262
250
}