@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix pretty drawings
Summary: Changes elsewhere which support spaces before "|" when defining a table so that tables quote properly also accidentally changed these beautiful drawings into remarkup tables.
Test Plan: (( o.O ))
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D15690
+8
+8
src/docs/user/userguide/arcanist_commit_ranges.diviner
+8
src/docs/user/userguide/arcanist_commit_ranges.diviner
···
193
193
194
194
This rule works well for trees that look like this:
195
195
196
+
```
196
197
| * Commit B1, on branch "subfeature" (HEAD)
197
198
| /
198
199
| * Commit A1, on branch "feature"
199
200
|/
200
201
* Commit M1, on branch "master"
201
202
|
203
+
```
202
204
203
205
This tree represents using feature branches to develop one feature ("feature"),
204
206
and then creating a sub-branch to develop a dependent feature ("subfeature").
···
218
220
However, this rule will select the wrong commit range in some cases. For
219
221
instance, it will do the wrong thing in this tree:
220
222
223
+
```
221
224
|
222
225
| * Commit A2, on branch "feature" (HEAD)
223
226
| |
···
227
230
|/
228
231
* Commit M1, on branch "master"
229
232
|
233
+
```
230
234
231
235
This tree represents making another commit (`A2`) on "feature", on top of `A1`.
232
236
···
240
244
241
245
This rule will also select the wrong commit range in a tree like this:
242
246
247
+
```
243
248
|
244
249
| * Commit A1', on branch "feature", created by amending A1
245
250
| |
···
249
254
|/
250
255
* Commit M1, on branch "master"
251
256
|
257
+
```
252
258
253
259
This tree represents amending `A1` without rebasing "subfeature", so that `A1`
254
260
is no longer on "feature" (replaced with `A1'`) but still on "subfeature". In
···
269
275
`.` and the selected base commit. It stops when it encounters a bookmark. For
270
276
example, if you have a tree like this:
271
277
278
+
```
272
279
|
273
280
| * C4 (outgoing, bookmark: stripes)
274
281
| |
···
278
285
|/
279
286
* C1 (pushed, no bookmark)
280
287
|
288
+
```
281
289
282
290
When run from `C4`, this rule will select just `C4`, stopping on `C3` because
283
291
it has a different bookmark. When run from `C3`, it will select `C2` and `C3`.