@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Enable 'jumping to toc' on diffusion commit page
Summary:
Diffusion page is sharing the keyboard shortcuts code with
Differential page. But since the toc (Changes) panel doesn't have id
'differential-review-toc', the 'jumping to toc' doesn't work. The fix is
to add the ID. I don't like adding 'Differential' to the Diffusion page.
Later we should refactor the code to extract the shared components out of Differential.
Test Plan:
verified that 't' worked on the diffusion commit page.
Reviewers: epriestley, nh
Reviewed By: epriestley
CC: hwang, aran, Korvin
Differential Revision: https://secure.phabricator.com/D2500
+1
+1
src/applications/diffusion/controller/DiffusionCommitController.php
+1
src/applications/diffusion/controller/DiffusionCommitController.php
···
162
162
} else {
163
163
$change_panel = new AphrontPanelView();
164
164
$change_panel->setHeader("Changes (".number_format($count).")");
165
+
$change_panel->setID('differential-review-toc');
165
166
166
167
if ($count !== $original_changes_count) {
167
168
$show_all_button = phutil_render_tag(