@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Rename "commitType" to "symbolicType"
Summary:
Ref T2683. The old name was a bit confusing because it meant "the type of the thing the symbol represents": a "commit type" should logically always be "commit".
(Currently, this is only used to detect when we're looking at a tag.)
Test Plan: Looked at a tag. Looked at some other non-tag things. Browsed around, `grep`.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T2683
Differential Revision: https://secure.phabricator.com/D9092
+7
-7
+1
-1
src/applications/diffusion/controller/DiffusionBrowseController.php
+1
-1
src/applications/diffusion/controller/DiffusionBrowseController.php
···
157
157
),
158
158
$drequest->getRepository()->formatCommitName($stable_commit)));
159
159
160
-
if ($drequest->getCommitType() == 'tag') {
160
+
if ($drequest->getSymbolicType() == 'tag') {
161
161
$symbolic = $drequest->getSymbolicCommit();
162
162
$view->addProperty(pht('Tag'), $symbolic);
163
163
+6
-6
src/applications/diffusion/request/DiffusionRequest.php
+6
-6
src/applications/diffusion/request/DiffusionRequest.php
···
16
16
protected $path;
17
17
protected $line;
18
18
protected $commit;
19
-
protected $commitType = 'commit';
20
19
protected $branch;
21
20
protected $lint;
22
21
23
22
protected $symbolicCommit;
23
+
protected $symbolicType;
24
24
protected $stableCommit;
25
25
26
26
protected $repository;
···
242
242
243
243
public function getSymbolicCommit() {
244
244
return $this->symbolicCommit;
245
+
}
246
+
247
+
public function getSymbolicType() {
248
+
return $this->symbolicType;
245
249
}
246
250
247
251
public function getBranch() {
···
630
634
$match = head($matches);
631
635
632
636
$this->commit = $match['identifier'];
633
-
$this->commitType = $match['type'];
634
-
}
635
-
636
-
public function getCommitType() {
637
-
return $this->commitType;
637
+
$this->symbolicType = $match['type'];
638
638
}
639
639
640
640
private function queryStableCommit() {