@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't add resources to Multimeter when there's no multimeter running
Summary: Fixes T8058. Don't add a Multimeter event if we aren't running multimeter (e.g., in unit tests).
Test Plan: Will `arc unit --everything`.
Reviewers: joshuaspence, btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T8058
Differential Revision: https://secure.phabricator.com/D12699
+5
-2
+5
-2
src/applications/celerity/CelerityStaticResourceResponse.php
+5
-2
src/applications/celerity/CelerityStaticResourceResponse.php
···
144
144
$uri = $this->getURI($map, $name);
145
145
$type = $map->getResourceTypeForName($name);
146
146
147
-
$event_type = MultimeterEvent::TYPE_STATIC_RESOURCE;
148
-
MultimeterControl::getInstance()->newEvent($event_type, 'rsrc.'.$name, 1);
147
+
$multimeter = MultimeterControl::getInstance();
148
+
if ($multimeter) {
149
+
$event_type = MultimeterEvent::TYPE_STATIC_RESOURCE;
150
+
$multimeter->newEvent($event_type, 'rsrc.'.$name, 1);
151
+
}
149
152
150
153
switch ($type) {
151
154
case 'css':