@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up Login, Responsive Forms
Summary: Removes the panel-view on login and adds additonal responsive styles for mobile forms.
Test Plan: View in mobile browser, resize page.
Reviewers: epriestley, btrahan
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D4530
+95
-52
+45
-45
src/__celerity_resource_map__.php
+45
-45
src/__celerity_resource_map__.php
···
611
611
),
612
612
'aphront-form-view-css' =>
613
613
array(
614
-
'uri' => '/res/bdc0b393/rsrc/css/aphront/form-view.css',
614
+
'uri' => '/res/45162273/rsrc/css/aphront/form-view.css',
615
615
'type' => 'css',
616
616
'requires' =>
617
617
array(
···
638
638
),
639
639
'aphront-list-filter-view-css' =>
640
640
array(
641
-
'uri' => '/res/f6d419df/rsrc/css/aphront/list-filter-view.css',
641
+
'uri' => '/res/e783d6e1/rsrc/css/aphront/list-filter-view.css',
642
642
'type' => 'css',
643
643
'requires' =>
644
644
array(
···
656
656
),
657
657
'aphront-panel-view-css' =>
658
658
array(
659
-
'uri' => '/res/2bafebac/rsrc/css/aphront/panel-view.css',
659
+
'uri' => '/res/e4ad41d7/rsrc/css/aphront/panel-view.css',
660
660
'type' => 'css',
661
661
'requires' =>
662
662
array(
···
861
861
),
862
862
'herald-css' =>
863
863
array(
864
-
'uri' => '/res/5051f3ab/rsrc/css/application/herald/herald.css',
864
+
'uri' => '/res/2150a55d/rsrc/css/application/herald/herald.css',
865
865
'type' => 'css',
866
866
'requires' =>
867
867
array(
···
870
870
),
871
871
'herald-rule-editor' =>
872
872
array(
873
-
'uri' => '/res/3a2979de/rsrc/js/application/herald/HeraldRuleEditor.js',
873
+
'uri' => '/res/f35d7e23/rsrc/js/application/herald/HeraldRuleEditor.js',
874
874
'type' => 'js',
875
875
'requires' =>
876
876
array(
···
3229
3229
), array(
3230
3230
'packages' =>
3231
3231
array(
3232
-
'7e7a7582' =>
3232
+
'6191f287' =>
3233
3233
array(
3234
3234
'name' => 'core.pkg.css',
3235
3235
'symbols' =>
···
3273
3273
36 => 'phabricator-object-item-list-view-css',
3274
3274
37 => 'global-drag-and-drop-css',
3275
3275
),
3276
-
'uri' => '/res/pkg/7e7a7582/core.pkg.css',
3276
+
'uri' => '/res/pkg/6191f287/core.pkg.css',
3277
3277
'type' => 'css',
3278
3278
),
3279
3279
'c90b892e' =>
···
3463
3463
'reverse' =>
3464
3464
array(
3465
3465
'aphront-attached-file-view-css' => '2a1ed97f',
3466
-
'aphront-crumbs-view-css' => '7e7a7582',
3467
-
'aphront-dialog-view-css' => '7e7a7582',
3468
-
'aphront-error-view-css' => '7e7a7582',
3469
-
'aphront-form-view-css' => '7e7a7582',
3466
+
'aphront-crumbs-view-css' => '6191f287',
3467
+
'aphront-dialog-view-css' => '6191f287',
3468
+
'aphront-error-view-css' => '6191f287',
3469
+
'aphront-form-view-css' => '6191f287',
3470
3470
'aphront-headsup-action-list-view-css' => 'ec01d039',
3471
-
'aphront-headsup-view-css' => '7e7a7582',
3472
-
'aphront-list-filter-view-css' => '7e7a7582',
3473
-
'aphront-pager-view-css' => '7e7a7582',
3474
-
'aphront-panel-view-css' => '7e7a7582',
3475
-
'aphront-table-view-css' => '7e7a7582',
3476
-
'aphront-tokenizer-control-css' => '7e7a7582',
3477
-
'aphront-tooltip-css' => '7e7a7582',
3478
-
'aphront-typeahead-control-css' => '7e7a7582',
3471
+
'aphront-headsup-view-css' => '6191f287',
3472
+
'aphront-list-filter-view-css' => '6191f287',
3473
+
'aphront-pager-view-css' => '6191f287',
3474
+
'aphront-panel-view-css' => '6191f287',
3475
+
'aphront-table-view-css' => '6191f287',
3476
+
'aphront-tokenizer-control-css' => '6191f287',
3477
+
'aphront-tooltip-css' => '6191f287',
3478
+
'aphront-typeahead-control-css' => '6191f287',
3479
3479
'differential-changeset-view-css' => 'ec01d039',
3480
3480
'differential-core-view-css' => 'ec01d039',
3481
3481
'differential-inline-comment-editor' => 'ac53d36a',
···
3489
3489
'differential-table-of-contents-css' => 'ec01d039',
3490
3490
'diffusion-commit-view-css' => 'c8ce2d88',
3491
3491
'diffusion-icons-css' => 'c8ce2d88',
3492
-
'global-drag-and-drop-css' => '7e7a7582',
3492
+
'global-drag-and-drop-css' => '6191f287',
3493
3493
'inline-comment-summary-css' => 'ec01d039',
3494
3494
'javelin-aphlict' => 'c90b892e',
3495
3495
'javelin-behavior' => 'fbeded59',
···
3559
3559
'javelin-util' => 'fbeded59',
3560
3560
'javelin-vector' => 'fbeded59',
3561
3561
'javelin-workflow' => 'fbeded59',
3562
-
'lightbox-attachment-css' => '7e7a7582',
3562
+
'lightbox-attachment-css' => '6191f287',
3563
3563
'maniphest-task-summary-css' => '2a1ed97f',
3564
3564
'maniphest-transaction-detail-css' => '2a1ed97f',
3565
3565
'phabricator-busy' => 'c90b892e',
3566
3566
'phabricator-content-source-view-css' => 'ec01d039',
3567
-
'phabricator-core-buttons-css' => '7e7a7582',
3568
-
'phabricator-core-css' => '7e7a7582',
3569
-
'phabricator-crumbs-view-css' => '7e7a7582',
3570
-
'phabricator-directory-css' => '7e7a7582',
3567
+
'phabricator-core-buttons-css' => '6191f287',
3568
+
'phabricator-core-css' => '6191f287',
3569
+
'phabricator-crumbs-view-css' => '6191f287',
3570
+
'phabricator-directory-css' => '6191f287',
3571
3571
'phabricator-drag-and-drop-file-upload' => 'ac53d36a',
3572
3572
'phabricator-dropdown-menu' => 'c90b892e',
3573
3573
'phabricator-file-upload' => 'c90b892e',
3574
-
'phabricator-filetree-view-css' => '7e7a7582',
3575
-
'phabricator-flag-css' => '7e7a7582',
3576
-
'phabricator-form-view-css' => '7e7a7582',
3577
-
'phabricator-header-view-css' => '7e7a7582',
3578
-
'phabricator-jump-nav' => '7e7a7582',
3574
+
'phabricator-filetree-view-css' => '6191f287',
3575
+
'phabricator-flag-css' => '6191f287',
3576
+
'phabricator-form-view-css' => '6191f287',
3577
+
'phabricator-header-view-css' => '6191f287',
3578
+
'phabricator-jump-nav' => '6191f287',
3579
3579
'phabricator-keyboard-shortcut' => 'c90b892e',
3580
3580
'phabricator-keyboard-shortcut-manager' => 'c90b892e',
3581
-
'phabricator-main-menu-view' => '7e7a7582',
3581
+
'phabricator-main-menu-view' => '6191f287',
3582
3582
'phabricator-menu-item' => 'c90b892e',
3583
-
'phabricator-nav-view-css' => '7e7a7582',
3583
+
'phabricator-nav-view-css' => '6191f287',
3584
3584
'phabricator-notification' => 'c90b892e',
3585
-
'phabricator-notification-css' => '7e7a7582',
3586
-
'phabricator-notification-menu-css' => '7e7a7582',
3587
-
'phabricator-object-item-list-view-css' => '7e7a7582',
3585
+
'phabricator-notification-css' => '6191f287',
3586
+
'phabricator-notification-menu-css' => '6191f287',
3587
+
'phabricator-object-item-list-view-css' => '6191f287',
3588
3588
'phabricator-object-selector-css' => 'ec01d039',
3589
3589
'phabricator-paste-file-upload' => 'c90b892e',
3590
3590
'phabricator-prefab' => 'c90b892e',
3591
3591
'phabricator-project-tag-css' => '2a1ed97f',
3592
-
'phabricator-remarkup-css' => '7e7a7582',
3592
+
'phabricator-remarkup-css' => '6191f287',
3593
3593
'phabricator-shaped-request' => 'ac53d36a',
3594
-
'phabricator-side-menu-view-css' => '7e7a7582',
3595
-
'phabricator-standard-page-view' => '7e7a7582',
3594
+
'phabricator-side-menu-view-css' => '6191f287',
3595
+
'phabricator-standard-page-view' => '6191f287',
3596
3596
'phabricator-textareautils' => 'c90b892e',
3597
3597
'phabricator-tooltip' => 'c90b892e',
3598
-
'phabricator-transaction-view-css' => '7e7a7582',
3599
-
'phabricator-zindex-css' => '7e7a7582',
3600
-
'sprite-apps-large-css' => '7e7a7582',
3601
-
'sprite-gradient-css' => '7e7a7582',
3602
-
'sprite-icon-css' => '7e7a7582',
3603
-
'sprite-menu-css' => '7e7a7582',
3604
-
'syntax-highlighting-css' => '7e7a7582',
3598
+
'phabricator-transaction-view-css' => '6191f287',
3599
+
'phabricator-zindex-css' => '6191f287',
3600
+
'sprite-apps-large-css' => '6191f287',
3601
+
'sprite-gradient-css' => '6191f287',
3602
+
'sprite-icon-css' => '6191f287',
3603
+
'sprite-menu-css' => '6191f287',
3604
+
'syntax-highlighting-css' => '6191f287',
3605
3605
),
3606
3606
));
+3
-1
src/applications/auth/controller/PhabricatorLoginController.php
+3
-1
src/applications/auth/controller/PhabricatorLoginController.php
···
282
282
283
283
$panel = new AphrontPanelView();
284
284
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
285
+
$panel->setNoBackground();
285
286
foreach ($forms as $name => $form) {
286
287
$panel->appendChild('<h1>'.$name.'</h1>');
287
288
$panel->appendChild($form);
···
290
291
291
292
$login_message = PhabricatorEnv::getEnvConfig('auth.login-message');
292
293
293
-
return $this->buildStandardPageResponse(
294
+
return $this->buildApplicationPage(
294
295
array(
295
296
$error_view,
296
297
$login_message,
···
298
299
),
299
300
array(
300
301
'title' => 'Login',
302
+
'device' => true
301
303
));
302
304
}
303
305
-1
src/applications/herald/controller/HeraldRuleController.php
-1
src/applications/herald/controller/HeraldRuleController.php
+1
src/applications/maniphest/controller/ManiphestTaskEditController.php
+1
src/applications/maniphest/controller/ManiphestTaskEditController.php
+26
webroot/rsrc/css/aphront/form-view.css
+26
webroot/rsrc/css/aphront/form-view.css
···
25
25
color: #666666;
26
26
}
27
27
28
+
.device-phone .aphront-form-view label.aphront-form-label {
29
+
display: block;
30
+
float: none;
31
+
text-align: left;
32
+
width: 100%;
33
+
}
34
+
28
35
.aphront-form-input {
29
36
margin-left: 20%;
30
37
margin-right: 25%;
31
38
width: 55%;
32
39
}
33
40
41
+
.device-phone .aphront-form-input {
42
+
margin-left: 0%;
43
+
margin-right: 0%;
44
+
width: 100%;
45
+
}
46
+
34
47
.aphront-form-control-text .aphront-form-input input,
35
48
.aphront-form-control-password .aphront-form-input input {
36
49
font-size: 13px;
···
49
62
color: #aa0000;
50
63
font-weight: bold;
51
64
padding-top: 4px;
65
+
}
66
+
67
+
.device-phone .aphront-form-error {
68
+
float: none;
69
+
width: 100%;
70
+
}
71
+
72
+
.device-phone .aphront-form-drag-and-drop-upload {
73
+
display: none;
52
74
}
53
75
54
76
.aphront-form-required {
···
103
125
text-align: right;
104
126
margin-right: 25%;
105
127
margin-left: 20%;
128
+
}
129
+
130
+
.device-phone .aphront-form-view .aphront-form-caption {
131
+
margin-right: 0%;
106
132
}
107
133
108
134
/* override for when inside an aphront-panel-view */
+6
webroot/rsrc/css/aphront/list-filter-view.css
+6
webroot/rsrc/css/aphront/list-filter-view.css
+6
-2
webroot/rsrc/css/aphront/panel-view.css
+6
-2
webroot/rsrc/css/aphront/panel-view.css
···
11
11
margin: 20px 20px 40px 20px;
12
12
}
13
13
14
+
.device-phone .aphront-panel-view {
15
+
margin: 20px 10px 40px 10px;
16
+
}
17
+
14
18
.aphront-unpadded-panel-view {
15
19
padding: 0;
16
20
}
···
52
56
font-size: 13px;
53
57
}
54
58
55
-
.aphront-panel-width-form {
59
+
.device-desktop .aphront-panel-width-form {
56
60
width: 720px;
57
61
margin-right: auto;
58
62
margin-left: auto;
59
63
}
60
64
61
-
.aphront-panel-width-wide {
65
+
.device-desktop .aphront-panel-width-wide {
62
66
width: 1080px;
63
67
margin-right: auto;
64
68
margin-left: auto;
+8
-2
webroot/rsrc/css/application/herald/herald.css
+8
-2
webroot/rsrc/css/application/herald/herald.css
···
8
8
}
9
9
10
10
.herald-condition-table select {
11
-
width: 250px;
11
+
width: 160px;
12
+
}
13
+
14
+
.device-phone .herald-condition-table select {
15
+
width: 90px;
12
16
}
13
17
14
18
.herald-action-table td,
···
23
27
24
28
.herald-action-table td input,
25
29
.herald-condition-table td input {
26
-
width: 460px;
30
+
width: 95%;
31
+
max-width: 460px;
32
+
padding: 2px 4px;
27
33
}
28
34
29
35
.herald-action-table td.target {