recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove "pretag" hook support in Mercurial

Summary: Ref T4195. This doesn't actually work like I thought it did: it only fires locally, when you run `hg tag`. Mercurial tags are also weird and basically don't make any sense and everyone should use bookmarks instead. We could implement some flavor of this eventually, but I'd like to see users request it first. They can implement their own with content-based hooks once those work, anyway.

Test Plan: This code didn't do anything.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4195

Differential Revision: https://secure.phabricator.com/D7765

epriestley 11b8e57a b326ef59

-12
-6
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
··· 432 432 return $this->findMercurialChangegroupRefUpdates(); 433 433 case 'prepushkey': 434 434 return $this->findMercurialPushKeyRefUpdates(); 435 - case 'pretag': 436 - return $this->findMercurialPreTagRefUpdates(); 437 435 default: 438 436 throw new Exception(pht('Unrecognized hook "%s"!', $hook)); 439 437 } ··· 691 689 ->setChangeFlags($ref_flags); 692 690 693 691 return array($ref_update); 694 - } 695 - 696 - private function findMercurialPreTagRefUpdates() { 697 - return array(); 698 692 } 699 693 700 694 private function findMercurialContentUpdates(array $ref_updates) {
-6
src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
··· 412 412 $repository->getCallsign(), 413 413 'prepushkey'); 414 414 415 - // This one handles creating tags. 416 - $data[] = csprintf( 417 - 'pretag.phabricator = %s %s %s', 418 - $bin, 419 - $repository->getCallsign(), 420 - 'pretag'); 421 415 $data[] = null; 422 416 423 417 $data = implode("\n", $data);