recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix some error log issues with uninitialized commit/revision lists

Summary:
Fixes T12679. Reproduction steps appear to be:

- As a logged-out user, view revision list or commit list.
- Enable bucketing by action required.
- Before patch: `foreach (null as ...)` causes error spew.
- After patch: `foreach (array() as ...)` works great.

Test Plan:
- Reproduced issue by following steps above in Differential (revisions) and Diffusion (audits/commits).
- After patches, no more errors in the log.

Reviewers: chad, amckinley

Reviewed By: chad

Maniphest Tasks: T12679

Differential Revision: https://secure.phabricator.com/D17872

epriestley 11c56388 db631b42

+2 -2
+1 -1
src/applications/audit/view/PhabricatorAuditListView.php
··· 2 2 3 3 final class PhabricatorAuditListView extends AphrontView { 4 4 5 - private $commits; 5 + private $commits = array(); 6 6 private $header; 7 7 private $showDrafts; 8 8 private $noDataString;
+1 -1
src/applications/differential/view/DifferentialRevisionListView.php
··· 5 5 */ 6 6 final class DifferentialRevisionListView extends AphrontView { 7 7 8 - private $revisions; 8 + private $revisions = array(); 9 9 private $handles; 10 10 private $header; 11 11 private $noDataString;