recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface

Summary:
Depends on D19919. Ref T11351. This method appeared in D8802 (note that "get...Object" was renamed to "get...Transaction" there, so this method was actually "new" even though a method of the same name had existed before).

The goal at the time was to let Harbormaster post build results to Diffs and have them end up on Revisions, but this eventually got a better implementation (see below) where the Harbormaster-specific code can just specify a "publishable object" where build results should go.

The new `get...Object` semantics ultimately broke some stuff, and the actual implementation in Differential was removed in D10911, so this method hasn't really served a purpose since December 2014. I think that broke the Harbormaster thing by accident and we just lived with it for a bit, then Harbormaster got some more work and D17139 introduced "publishable" objects which was a better approach. This was later refined by D19281.

So: the original problem (sending build results to the right place) has a good solution now, this method hasn't done anything for 4 years, and it was probably a bad idea in the first place since it's pretty weird/surprising/fragile.

Note that `Comment` objects still have an unrelated method with the same name. In that case, the method ties the `Comment` storage object to the related `Transaction` storage object.

Test Plan: Grepped for `getApplicationTransactionObject`, verified that all remaining callsites are related to `Comment` objects.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T11351

Differential Revision: https://secure.phabricator.com/D19920

epriestley 11cf8f05 937e88c3

+6 -328
-4
src/applications/almanac/storage/AlmanacBinding.php
··· 206 206 return new AlmanacBindingEditor(); 207 207 } 208 208 209 - public function getApplicationTransactionObject() { 210 - return $this; 211 - } 212 - 213 209 public function getApplicationTransactionTemplate() { 214 210 return new AlmanacBindingTransaction(); 215 211 }
-4
src/applications/almanac/storage/AlmanacDevice.php
··· 204 204 return new AlmanacDeviceEditor(); 205 205 } 206 206 207 - public function getApplicationTransactionObject() { 208 - return $this; 209 - } 210 - 211 207 public function getApplicationTransactionTemplate() { 212 208 return new AlmanacDeviceTransaction(); 213 209 }
-4
src/applications/almanac/storage/AlmanacInterface.php
··· 168 168 return new AlmanacInterfaceEditor(); 169 169 } 170 170 171 - public function getApplicationTransactionObject() { 172 - return $this; 173 - } 174 - 175 171 public function getApplicationTransactionTemplate() { 176 172 return new AlmanacInterfaceTransaction(); 177 173 }
-4
src/applications/almanac/storage/AlmanacNamespace.php
··· 191 191 return new AlmanacNamespaceEditor(); 192 192 } 193 193 194 - public function getApplicationTransactionObject() { 195 - return $this; 196 - } 197 - 198 194 public function getApplicationTransactionTemplate() { 199 195 return new AlmanacNamespaceTransaction(); 200 196 }
-4
src/applications/almanac/storage/AlmanacNetwork.php
··· 61 61 return new AlmanacNetworkEditor(); 62 62 } 63 63 64 - public function getApplicationTransactionObject() { 65 - return $this; 66 - } 67 - 68 64 public function getApplicationTransactionTemplate() { 69 65 return new AlmanacNetworkTransaction(); 70 66 }
-4
src/applications/almanac/storage/AlmanacService.php
··· 226 226 return new AlmanacServiceEditor(); 227 227 } 228 228 229 - public function getApplicationTransactionObject() { 230 - return $this; 231 - } 232 - 233 229 public function getApplicationTransactionTemplate() { 234 230 return new AlmanacServiceTransaction(); 235 231 }
-4
src/applications/auth/storage/PhabricatorAuthPassword.php
··· 217 217 return new PhabricatorAuthPasswordEditor(); 218 218 } 219 219 220 - public function getApplicationTransactionObject() { 221 - return $this; 222 - } 223 - 224 220 public function getApplicationTransactionTemplate() { 225 221 return new PhabricatorAuthPasswordTransaction(); 226 222 }
-4
src/applications/auth/storage/PhabricatorAuthProviderConfig.php
··· 91 91 return new PhabricatorAuthProviderConfigEditor(); 92 92 } 93 93 94 - public function getApplicationTransactionObject() { 95 - return $this; 96 - } 97 - 98 94 public function getApplicationTransactionTemplate() { 99 95 return new PhabricatorAuthProviderConfigTransaction(); 100 96 }
-4
src/applications/auth/storage/PhabricatorAuthSSHKey.php
··· 159 159 return new PhabricatorAuthSSHKeyEditor(); 160 160 } 161 161 162 - public function getApplicationTransactionObject() { 163 - return $this; 164 - } 165 - 166 162 public function getApplicationTransactionTemplate() { 167 163 return new PhabricatorAuthSSHKeyTransaction(); 168 164 }
-4
src/applications/badges/storage/PhabricatorBadgesBadge.php
··· 125 125 return new PhabricatorBadgesEditor(); 126 126 } 127 127 128 - public function getApplicationTransactionObject() { 129 - return $this; 130 - } 131 - 132 128 public function getApplicationTransactionTemplate() { 133 129 return new PhabricatorBadgesTransaction(); 134 130 }
-4
src/applications/base/PhabricatorApplication.php
··· 649 649 return new PhabricatorApplicationEditor(); 650 650 } 651 651 652 - public function getApplicationTransactionObject() { 653 - return $this; 654 - } 655 - 656 652 public function getApplicationTransactionTemplate() { 657 653 return new PhabricatorApplicationApplicationTransaction(); 658 654 }
-4
src/applications/calendar/storage/PhabricatorCalendarEvent.php
··· 1311 1311 return new PhabricatorCalendarEventEditor(); 1312 1312 } 1313 1313 1314 - public function getApplicationTransactionObject() { 1315 - return $this; 1316 - } 1317 - 1318 1314 public function getApplicationTransactionTemplate() { 1319 1315 return new PhabricatorCalendarEventTransaction(); 1320 1316 }
-4
src/applications/calendar/storage/PhabricatorCalendarExport.php
··· 166 166 return new PhabricatorCalendarExportEditor(); 167 167 } 168 168 169 - public function getApplicationTransactionObject() { 170 - return $this; 171 - } 172 - 173 169 public function getApplicationTransactionTemplate() { 174 170 return new PhabricatorCalendarExportTransaction(); 175 171 }
-4
src/applications/calendar/storage/PhabricatorCalendarImport.php
··· 140 140 return new PhabricatorCalendarImportEditor(); 141 141 } 142 142 143 - public function getApplicationTransactionObject() { 144 - return $this; 145 - } 146 - 147 143 public function getApplicationTransactionTemplate() { 148 144 return new PhabricatorCalendarImportTransaction(); 149 145 }
-4
src/applications/config/storage/PhabricatorConfigEntry.php
··· 61 61 return new PhabricatorConfigEditor(); 62 62 } 63 63 64 - public function getApplicationTransactionObject() { 65 - return $this; 66 - } 67 - 68 64 public function getApplicationTransactionTemplate() { 69 65 return new PhabricatorConfigTransaction(); 70 66 }
-4
src/applications/conpherence/storage/ConpherenceThread.php
··· 311 311 return new ConpherenceEditor(); 312 312 } 313 313 314 - public function getApplicationTransactionObject() { 315 - return $this; 316 - } 317 - 318 314 public function getApplicationTransactionTemplate() { 319 315 return new ConpherenceTransaction(); 320 316 }
-4
src/applications/countdown/storage/PhabricatorCountdown.php
··· 95 95 return new PhabricatorCountdownEditor(); 96 96 } 97 97 98 - public function getApplicationTransactionObject() { 99 - return $this; 100 - } 101 - 102 98 public function getApplicationTransactionTemplate() { 103 99 return new PhabricatorCountdownTransaction(); 104 100 }
-4
src/applications/dashboard/storage/PhabricatorDashboard.php
··· 130 130 return new PhabricatorDashboardTransactionEditor(); 131 131 } 132 132 133 - public function getApplicationTransactionObject() { 134 - return $this; 135 - } 136 - 137 133 public function getApplicationTransactionTemplate() { 138 134 return new PhabricatorDashboardTransaction(); 139 135 }
-4
src/applications/dashboard/storage/PhabricatorDashboardPanel.php
··· 113 113 return new PhabricatorDashboardPanelTransactionEditor(); 114 114 } 115 115 116 - public function getApplicationTransactionObject() { 117 - return $this; 118 - } 119 - 120 116 public function getApplicationTransactionTemplate() { 121 117 return new PhabricatorDashboardPanelTransaction(); 122 118 }
-4
src/applications/differential/storage/DifferentialDiff.php
··· 699 699 return new DifferentialDiffEditor(); 700 700 } 701 701 702 - public function getApplicationTransactionObject() { 703 - return $this; 704 - } 705 - 706 702 public function getApplicationTransactionTemplate() { 707 703 return new DifferentialDiffTransaction(); 708 704 }
-4
src/applications/differential/storage/DifferentialRevision.php
··· 991 991 return new DifferentialTransactionEditor(); 992 992 } 993 993 994 - public function getApplicationTransactionObject() { 995 - return $this; 996 - } 997 - 998 994 public function getApplicationTransactionTemplate() { 999 995 return new DifferentialTransaction(); 1000 996 }
-4
src/applications/diviner/storage/DivinerLiveBook.php
··· 143 143 return new DivinerLiveBookEditor(); 144 144 } 145 145 146 - public function getApplicationTransactionObject() { 147 - return $this; 148 - } 149 - 150 146 public function getApplicationTransactionTemplate() { 151 147 return new DivinerLiveBookTransaction(); 152 148 }
-4
src/applications/drydock/storage/DrydockBlueprint.php
··· 295 295 return new DrydockBlueprintEditor(); 296 296 } 297 297 298 - public function getApplicationTransactionObject() { 299 - return $this; 300 - } 301 - 302 298 public function getApplicationTransactionTemplate() { 303 299 return new DrydockBlueprintTransaction(); 304 300 }
-4
src/applications/files/storage/PhabricatorFile.php
··· 1544 1544 return new PhabricatorFileEditor(); 1545 1545 } 1546 1546 1547 - public function getApplicationTransactionObject() { 1548 - return $this; 1549 - } 1550 - 1551 1547 public function getApplicationTransactionTemplate() { 1552 1548 return new PhabricatorFileTransaction(); 1553 1549 }
-4
src/applications/fund/storage/FundBacker.php
··· 110 110 return new FundBackerEditor(); 111 111 } 112 112 113 - public function getApplicationTransactionObject() { 114 - return $this; 115 - } 116 - 117 113 public function getApplicationTransactionTemplate() { 118 114 return new FundBackerTransaction(); 119 115 }
-4
src/applications/fund/storage/FundInitiative.php
··· 160 160 return new FundInitiativeEditor(); 161 161 } 162 162 163 - public function getApplicationTransactionObject() { 164 - return $this; 165 - } 166 - 167 163 public function getApplicationTransactionTemplate() { 168 164 return new FundInitiativeTransaction(); 169 165 }
+1 -3
src/applications/harbormaster/engine/HarbormasterBuildableEngine.php
··· 96 96 $publishable = $this->getPublishableObject(); 97 97 $editor = $this->newEditor(); 98 98 99 - $editor->applyTransactions( 100 - $publishable->getApplicationTransactionObject(), 101 - $xactions); 99 + $editor->applyTransactions($publishable, $xactions); 102 100 } 103 101 104 102 public function getAuthorIdentity() {
-4
src/applications/harbormaster/storage/HarbormasterBuildable.php
··· 283 283 return new HarbormasterBuildableTransactionEditor(); 284 284 } 285 285 286 - public function getApplicationTransactionObject() { 287 - return $this; 288 - } 289 - 290 286 public function getApplicationTransactionTemplate() { 291 287 return new HarbormasterBuildableTransaction(); 292 288 }
-4
src/applications/harbormaster/storage/build/HarbormasterBuild.php
··· 393 393 return new HarbormasterBuildTransactionEditor(); 394 394 } 395 395 396 - public function getApplicationTransactionObject() { 397 - return $this; 398 - } 399 - 400 396 public function getApplicationTransactionTemplate() { 401 397 return new HarbormasterBuildTransaction(); 402 398 }
-4
src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php
··· 136 136 return new HarbormasterBuildPlanEditor(); 137 137 } 138 138 139 - public function getApplicationTransactionObject() { 140 - return $this; 141 - } 142 - 143 139 public function getApplicationTransactionTemplate() { 144 140 return new HarbormasterBuildPlanTransaction(); 145 141 }
-4
src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php
··· 121 121 return new HarbormasterBuildStepEditor(); 122 122 } 123 123 124 - public function getApplicationTransactionObject() { 125 - return $this; 126 - } 127 - 128 124 public function getApplicationTransactionTemplate() { 129 125 return new HarbormasterBuildStepTransaction(); 130 126 }
-4
src/applications/herald/storage/HeraldRule.php
··· 318 318 return new HeraldRuleEditor(); 319 319 } 320 320 321 - public function getApplicationTransactionObject() { 322 - return $this; 323 - } 324 - 325 321 public function getApplicationTransactionTemplate() { 326 322 return new HeraldRuleTransaction(); 327 323 }
-4
src/applications/herald/storage/HeraldWebhook.php
··· 200 200 return new HeraldWebhookEditor(); 201 201 } 202 202 203 - public function getApplicationTransactionObject() { 204 - return $this; 205 - } 206 - 207 203 public function getApplicationTransactionTemplate() { 208 204 return new HeraldWebhookTransaction(); 209 205 }
-4
src/applications/legalpad/storage/LegalpadDocument.php
··· 209 209 return new LegalpadDocumentEditor(); 210 210 } 211 211 212 - public function getApplicationTransactionObject() { 213 - return $this; 214 - } 215 - 216 212 public function getApplicationTransactionTemplate() { 217 213 return new LegalpadTransaction(); 218 214 }
-4
src/applications/macro/storage/PhabricatorFileImageMacro.php
··· 98 98 return new PhabricatorMacroEditor(); 99 99 } 100 100 101 - public function getApplicationTransactionObject() { 102 - return $this; 103 - } 104 - 105 101 public function getApplicationTransactionTemplate() { 106 102 return new PhabricatorMacroTransaction(); 107 103 }
-4
src/applications/maniphest/storage/ManiphestTask.php
··· 452 452 return new ManiphestTransactionEditor(); 453 453 } 454 454 455 - public function getApplicationTransactionObject() { 456 - return $this; 457 - } 458 - 459 455 public function getApplicationTransactionTemplate() { 460 456 return new ManiphestTransaction(); 461 457 }
-4
src/applications/metamta/storage/PhabricatorMetaMTAApplicationEmail.php
··· 123 123 return new PhabricatorMetaMTAApplicationEmailEditor(); 124 124 } 125 125 126 - public function getApplicationTransactionObject() { 127 - return $this; 128 - } 129 - 130 126 public function getApplicationTransactionTemplate() { 131 127 return new PhabricatorMetaMTAApplicationEmailTransaction(); 132 128 }
-4
src/applications/nuance/storage/NuanceItem.php
··· 193 193 return new NuanceItemEditor(); 194 194 } 195 195 196 - public function getApplicationTransactionObject() { 197 - return $this; 198 - } 199 - 200 196 public function getApplicationTransactionTemplate() { 201 197 return new NuanceItemTransaction(); 202 198 }
-4
src/applications/nuance/storage/NuanceQueue.php
··· 79 79 return new NuanceQueueEditor(); 80 80 } 81 81 82 - public function getApplicationTransactionObject() { 83 - return $this; 84 - } 85 - 86 82 public function getApplicationTransactionTemplate() { 87 83 return new NuanceQueueTransaction(); 88 84 }
-4
src/applications/nuance/storage/NuanceSource.php
··· 99 99 return new NuanceSourceEditor(); 100 100 } 101 101 102 - public function getApplicationTransactionObject() { 103 - return $this; 104 - } 105 - 106 102 public function getApplicationTransactionTemplate() { 107 103 return new NuanceSourceTransaction(); 108 104 }
-4
src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php
··· 91 91 return new PhabricatorOAuthServerEditor(); 92 92 } 93 93 94 - public function getApplicationTransactionObject() { 95 - return $this; 96 - } 97 - 98 94 public function getApplicationTransactionTemplate() { 99 95 return new PhabricatorOAuthServerTransaction(); 100 96 }
-4
src/applications/owners/storage/PhabricatorOwnersPackage.php
··· 607 607 return new PhabricatorOwnersPackageTransactionEditor(); 608 608 } 609 609 610 - public function getApplicationTransactionObject() { 611 - return $this; 612 - } 613 - 614 610 public function getApplicationTransactionTemplate() { 615 611 return new PhabricatorOwnersPackageTransaction(); 616 612 }
-4
src/applications/packages/storage/PhabricatorPackagesPackage.php
··· 189 189 return new PhabricatorPackagesPackageEditor(); 190 190 } 191 191 192 - public function getApplicationTransactionObject() { 193 - return $this; 194 - } 195 - 196 192 public function getApplicationTransactionTemplate() { 197 193 return new PhabricatorPackagesPackageTransaction(); 198 194 }
-4
src/applications/packages/storage/PhabricatorPackagesPublisher.php
··· 165 165 return new PhabricatorPackagesPublisherEditor(); 166 166 } 167 167 168 - public function getApplicationTransactionObject() { 169 - return $this; 170 - } 171 - 172 168 public function getApplicationTransactionTemplate() { 173 169 return new PhabricatorPackagesPublisherTransaction(); 174 170 }
-4
src/applications/packages/storage/PhabricatorPackagesVersion.php
··· 156 156 return new PhabricatorPackagesVersionEditor(); 157 157 } 158 158 159 - public function getApplicationTransactionObject() { 160 - return $this; 161 - } 162 - 163 159 public function getApplicationTransactionTemplate() { 164 160 return new PhabricatorPackagesVersionTransaction(); 165 161 }
-4
src/applications/passphrase/storage/PassphraseCredential.php
··· 117 117 return new PassphraseCredentialTransactionEditor(); 118 118 } 119 119 120 - public function getApplicationTransactionObject() { 121 - return $this; 122 - } 123 - 124 120 public function getApplicationTransactionTemplate() { 125 121 return new PassphraseCredentialTransaction(); 126 122 }
-4
src/applications/paste/storage/PhabricatorPaste.php
··· 219 219 return new PhabricatorPasteEditor(); 220 220 } 221 221 222 - public function getApplicationTransactionObject() { 223 - return $this; 224 - } 225 - 226 222 public function getApplicationTransactionTemplate() { 227 223 return new PhabricatorPasteTransaction(); 228 224 }
-4
src/applications/people/storage/PhabricatorUser.php
··· 1371 1371 return new PhabricatorUserTransactionEditor(); 1372 1372 } 1373 1373 1374 - public function getApplicationTransactionObject() { 1375 - return $this; 1376 - } 1377 - 1378 1374 public function getApplicationTransactionTemplate() { 1379 1375 return new PhabricatorUserTransaction(); 1380 1376 }
-4
src/applications/phame/storage/PhameBlog.php
··· 331 331 return new PhameBlogEditor(); 332 332 } 333 333 334 - public function getApplicationTransactionObject() { 335 - return $this; 336 - } 337 - 338 334 public function getApplicationTransactionTemplate() { 339 335 return new PhameBlogTransaction(); 340 336 }
-4
src/applications/phame/storage/PhamePost.php
··· 279 279 return new PhamePostEditor(); 280 280 } 281 281 282 - public function getApplicationTransactionObject() { 283 - return $this; 284 - } 285 - 286 282 public function getApplicationTransactionTemplate() { 287 283 return new PhamePostTransaction(); 288 284 }
-4
src/applications/phlux/storage/PhluxVariable.php
··· 41 41 return new PhluxVariableEditor(); 42 42 } 43 43 44 - public function getApplicationTransactionObject() { 45 - return $this; 46 - } 47 - 48 44 public function getApplicationTransactionTemplate() { 49 45 return new PhluxTransaction(); 50 46 }
-4
src/applications/pholio/storage/PholioMock.php
··· 221 221 return new PholioMockEditor(); 222 222 } 223 223 224 - public function getApplicationTransactionObject() { 225 - return $this; 226 - } 227 - 228 224 public function getApplicationTransactionTemplate() { 229 225 return new PholioTransaction(); 230 226 }
-4
src/applications/phortune/storage/PhortuneAccount.php
··· 105 105 return new PhortuneAccountEditor(); 106 106 } 107 107 108 - public function getApplicationTransactionObject() { 109 - return $this; 110 - } 111 - 112 108 public function getApplicationTransactionTemplate() { 113 109 return new PhortuneAccountTransaction(); 114 110 }
-4
src/applications/phortune/storage/PhortuneCart.php
··· 636 636 return new PhortuneCartEditor(); 637 637 } 638 638 639 - public function getApplicationTransactionObject() { 640 - return $this; 641 - } 642 - 643 639 public function getApplicationTransactionTemplate() { 644 640 return new PhortuneCartTransaction(); 645 641 }
-4
src/applications/phortune/storage/PhortuneMerchant.php
··· 78 78 return new PhortuneMerchantEditor(); 79 79 } 80 80 81 - public function getApplicationTransactionObject() { 82 - return $this; 83 - } 84 - 85 81 public function getApplicationTransactionTemplate() { 86 82 return new PhortuneMerchantTransaction(); 87 83 }
-4
src/applications/phortune/storage/PhortunePaymentProviderConfig.php
··· 106 106 return new PhortunePaymentProviderConfigEditor(); 107 107 } 108 108 109 - public function getApplicationTransactionObject() { 110 - return $this; 111 - } 112 - 113 109 public function getApplicationTransactionTemplate() { 114 110 return new PhortunePaymentProviderConfigTransaction(); 115 111 }
-4
src/applications/phriction/storage/PhrictionDocument.php
··· 223 223 return new PhrictionTransactionEditor(); 224 224 } 225 225 226 - public function getApplicationTransactionObject() { 227 - return $this; 228 - } 229 - 230 226 public function getApplicationTransactionTemplate() { 231 227 return new PhrictionTransaction(); 232 228 }
-4
src/applications/phurl/storage/PhabricatorPhurlURL.php
··· 157 157 return new PhabricatorPhurlURLEditor(); 158 158 } 159 159 160 - public function getApplicationTransactionObject() { 161 - return $this; 162 - } 163 - 164 160 public function getApplicationTransactionTemplate() { 165 161 return new PhabricatorPhurlURLTransaction(); 166 162 }
-4
src/applications/ponder/storage/PonderAnswer.php
··· 117 117 return new PonderAnswerEditor(); 118 118 } 119 119 120 - public function getApplicationTransactionObject() { 121 - return $this; 122 - } 123 - 124 120 public function getApplicationTransactionTemplate() { 125 121 return new PonderAnswerTransaction(); 126 122 }
-4
src/applications/ponder/storage/PonderQuestion.php
··· 145 145 return new PonderQuestionEditor(); 146 146 } 147 147 148 - public function getApplicationTransactionObject() { 149 - return $this; 150 - } 151 - 152 148 public function getApplicationTransactionTemplate() { 153 149 return new PonderQuestionTransaction(); 154 150 }
-4
src/applications/project/storage/PhabricatorProject.php
··· 695 695 return new PhabricatorProjectTransactionEditor(); 696 696 } 697 697 698 - public function getApplicationTransactionObject() { 699 - return $this; 700 - } 701 - 702 698 public function getApplicationTransactionTemplate() { 703 699 return new PhabricatorProjectTransaction(); 704 700 }
-4
src/applications/project/storage/PhabricatorProjectColumn.php
··· 234 234 return new PhabricatorProjectColumnTransactionEditor(); 235 235 } 236 236 237 - public function getApplicationTransactionObject() { 238 - return $this; 239 - } 240 - 241 237 public function getApplicationTransactionTemplate() { 242 238 return new PhabricatorProjectColumnTransaction(); 243 239 }
-4
src/applications/releeph/storage/ReleephBranch.php
··· 158 158 return new ReleephBranchEditor(); 159 159 } 160 160 161 - public function getApplicationTransactionObject() { 162 - return $this; 163 - } 164 - 165 161 public function getApplicationTransactionTemplate() { 166 162 return new ReleephBranchTransaction(); 167 163 }
-4
src/applications/releeph/storage/ReleephProject.php
··· 119 119 return new ReleephProductEditor(); 120 120 } 121 121 122 - public function getApplicationTransactionObject() { 123 - return $this; 124 - } 125 - 126 122 public function getApplicationTransactionTemplate() { 127 123 return new ReleephProductTransaction(); 128 124 }
-4
src/applications/releeph/storage/ReleephRequest.php
··· 299 299 return new ReleephRequestTransactionalEditor(); 300 300 } 301 301 302 - public function getApplicationTransactionObject() { 303 - return $this; 304 - } 305 - 306 302 public function getApplicationTransactionTemplate() { 307 303 return new ReleephRequestTransaction(); 308 304 }
-4
src/applications/repository/storage/PhabricatorRepository.php
··· 2613 2613 return new PhabricatorRepositoryEditor(); 2614 2614 } 2615 2615 2616 - public function getApplicationTransactionObject() { 2617 - return $this; 2618 - } 2619 - 2620 2616 public function getApplicationTransactionTemplate() { 2621 2617 return new PhabricatorRepositoryTransaction(); 2622 2618 }
-4
src/applications/repository/storage/PhabricatorRepositoryCommit.php
··· 731 731 return new PhabricatorAuditEditor(); 732 732 } 733 733 734 - public function getApplicationTransactionObject() { 735 - return $this; 736 - } 737 - 738 734 public function getApplicationTransactionTemplate() { 739 735 return new PhabricatorAuditTransaction(); 740 736 }
-4
src/applications/repository/storage/PhabricatorRepositoryIdentity.php
··· 134 134 return new DiffusionRepositoryIdentityEditor(); 135 135 } 136 136 137 - public function getApplicationTransactionObject() { 138 - return $this; 139 - } 140 - 141 137 public function getApplicationTransactionTemplate() { 142 138 return new PhabricatorRepositoryIdentityTransaction(); 143 139 }
-4
src/applications/repository/storage/PhabricatorRepositoryURI.php
··· 605 605 return new DiffusionURIEditor(); 606 606 } 607 607 608 - public function getApplicationTransactionObject() { 609 - return $this; 610 - } 611 - 612 608 public function getApplicationTransactionTemplate() { 613 609 return new PhabricatorRepositoryURITransaction(); 614 610 }
-4
src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php
··· 265 265 return new PhabricatorProfileMenuEditor(); 266 266 } 267 267 268 - public function getApplicationTransactionObject() { 269 - return $this; 270 - } 271 - 272 268 public function getApplicationTransactionTemplate() { 273 269 return new PhabricatorProfileMenuItemConfigurationTransaction(); 274 270 }
-4
src/applications/settings/storage/PhabricatorUserPreferences.php
··· 245 245 return new PhabricatorUserPreferencesEditor(); 246 246 } 247 247 248 - public function getApplicationTransactionObject() { 249 - return $this; 250 - } 251 - 252 248 public function getApplicationTransactionTemplate() { 253 249 return new PhabricatorUserPreferencesTransaction(); 254 250 }
-4
src/applications/slowvote/storage/PhabricatorSlowvotePoll.php
··· 131 131 return new PhabricatorSlowvoteEditor(); 132 132 } 133 133 134 - public function getApplicationTransactionObject() { 135 - return $this; 136 - } 137 - 138 134 public function getApplicationTransactionTemplate() { 139 135 return new PhabricatorSlowvoteTransaction(); 140 136 }
-4
src/applications/spaces/storage/PhabricatorSpacesNamespace.php
··· 91 91 return new PhabricatorSpacesNamespaceEditor(); 92 92 } 93 93 94 - public function getApplicationTransactionObject() { 95 - return $this; 96 - } 97 - 98 94 public function getApplicationTransactionTemplate() { 99 95 return new PhabricatorSpacesNamespaceTransaction(); 100 96 }
+1 -3
src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php
··· 77 77 ->setContinueOnMissingFields(true) 78 78 ->setContentSourceFromRequest($request); 79 79 80 - $editor->applyTransactions( 81 - $object->getApplicationTransactionObject(), 82 - array($xaction)); 80 + $editor->applyTransactions($object, array($xaction)); 83 81 } else { 84 82 85 83 // TODO: Eventually, get rid of this once everything implements
+1 -3
src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php
··· 55 55 ->setContinueOnMissingFields(true) 56 56 ->setContentSourceFromRequest($request); 57 57 58 - $editor->applyTransactions( 59 - $object->getApplicationTransactionObject(), 60 - array($xaction)); 58 + $editor->applyTransactions($object, array($xaction)); 61 59 62 60 return id(new AphrontReloadResponse())->setURI($object_uri); 63 61 }
+1 -3
src/applications/tokens/editor/PhabricatorTokenGivenEditor.php
··· 166 166 ->setContinueOnNoEffect(true) 167 167 ->setContinueOnMissingFields(true); 168 168 169 - $editor->applyTransactions( 170 - $object->getApplicationTransactionObject(), 171 - $xactions); 169 + $editor->applyTransactions($object, $xactions); 172 170 } 173 171 174 172 }
+1 -2
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
··· 3766 3766 3767 3767 $editor = $node->getApplicationTransactionEditor(); 3768 3768 $template = $node->getApplicationTransactionTemplate(); 3769 - $target = $node->getApplicationTransactionObject(); 3770 3769 3771 3770 if (isset($add[$node->getPHID()])) { 3772 3771 $edge_edit_type = '+'; ··· 3792 3791 ->setActingAsPHID($this->getActingAsPHID()) 3793 3792 ->setContentSource($this->getContentSource()); 3794 3793 3795 - $editor->applyTransactions($target, array($template)); 3794 + $editor->applyTransactions($node, array($template)); 3796 3795 } 3797 3796 } 3798 3797
-15
src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php
··· 18 18 19 19 20 20 /** 21 - * Return the object to apply transactions to. Normally this is the current 22 - * object (that is, `$this`), but in some cases transactions may apply to 23 - * a different object: for example, @{class:DifferentialDiff} applies 24 - * transactions to the associated @{class:DifferentialRevision}. 25 - * 26 - * @return PhabricatorLiskDAO Object to apply transactions to. 27 - */ 28 - public function getApplicationTransactionObject(); 29 - 30 - 31 - /** 32 21 * Return a template transaction for this object. 33 22 * 34 23 * @return PhabricatorApplicationTransaction ··· 45 34 46 35 public function getApplicationTransactionEditor() { 47 36 return new <<<???>>>Editor(); 48 - } 49 - 50 - public function getApplicationTransactionObject() { 51 - return $this; 52 37 } 53 38 54 39 public function getApplicationTransactionTemplate() {
+1 -3
src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php
··· 107 107 ->attachComment($comment); 108 108 } 109 109 110 - $target = $object->getApplicationTransactionObject(); 111 - 112 110 $this->newEditor($mail) 113 111 ->setContinueOnNoEffect(true) 114 - ->applyTransactions($target, $xactions); 112 + ->applyTransactions($object, $xactions); 115 113 } 116 114 117 115 private function processMailCommands(
-4
src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php
··· 339 339 return new PhabricatorEditEngineConfigurationEditor(); 340 340 } 341 341 342 - public function getApplicationTransactionObject() { 343 - return $this; 344 - } 345 - 346 342 public function getApplicationTransactionTemplate() { 347 343 return new PhabricatorEditEngineConfigurationTransaction(); 348 344 }
-4
src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php
··· 233 233 return new PhabricatorWorkerBulkJobEditor(); 234 234 } 235 235 236 - public function getApplicationTransactionObject() { 237 - return $this; 238 - } 239 - 240 236 public function getApplicationTransactionTemplate() { 241 237 return new PhabricatorWorkerBulkJobTransaction(); 242 238 }