recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

[Redesign] PHUICrumbs touchups

Summary: Ref T8099, minor adds back the border, makes blue highlight {$blue}

Test Plan: Hover over new crumbs, match header hovers. Check Phriction for border

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D12959

Chad Little 11ed4e4f 3cd27a08

+17 -18
+5 -5
resources/celerity/map.php
··· 7 7 */ 8 8 return array( 9 9 'names' => array( 10 - 'core.pkg.css' => '6bad4591', 10 + 'core.pkg.css' => '4362e142', 11 11 'core.pkg.js' => 'f3e08b38', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 13 'differential.pkg.css' => 'bb338e4b', ··· 34 34 'rsrc/css/aphront/typeahead.css' => '0e403212', 35 35 'rsrc/css/application/almanac/almanac.css' => 'dbb9b3af', 36 36 'rsrc/css/application/auth/auth.css' => '44975d4b', 37 - 'rsrc/css/application/base/main-menu-view.css' => '680360ea', 37 + 'rsrc/css/application/base/main-menu-view.css' => '4b7ecab2', 38 38 'rsrc/css/application/base/notification-menu.css' => '713df25a', 39 39 'rsrc/css/application/base/phabricator-application-launch-view.css' => '132f9d14', 40 40 'rsrc/css/application/base/standard-page-view.css' => '062f0f54', ··· 127 127 'rsrc/css/phui/phui-action-panel.css' => '3ee9afd5', 128 128 'rsrc/css/phui/phui-box.css' => 'a5bb366d', 129 129 'rsrc/css/phui/phui-button.css' => 'b995182d', 130 - 'rsrc/css/phui/phui-crumbs-view.css' => 'aeff7a21', 130 + 'rsrc/css/phui/phui-crumbs-view.css' => '3840dc4c', 131 131 'rsrc/css/phui/phui-document.css' => '8be7a5e3', 132 132 'rsrc/css/phui/phui-feed-story.css' => 'c9f3a0b5', 133 133 'rsrc/css/phui/phui-fontkit.css' => 'b664ac96', ··· 711 711 'phabricator-hovercard-view-css' => 'd2a28ca5', 712 712 'phabricator-keyboard-shortcut' => '1ae869f2', 713 713 'phabricator-keyboard-shortcut-manager' => 'c1700f6f', 714 - 'phabricator-main-menu-view' => '680360ea', 714 + 'phabricator-main-menu-view' => '4b7ecab2', 715 715 'phabricator-nav-view-css' => '949b43d9', 716 716 'phabricator-notification' => '0c6946e7', 717 717 'phabricator-notification-css' => '9c279160', ··· 758 758 'phui-calendar-day-css' => '38891735', 759 759 'phui-calendar-list-css' => 'c1d0ca59', 760 760 'phui-calendar-month-css' => '75e6a2ee', 761 - 'phui-crumbs-view-css' => 'aeff7a21', 761 + 'phui-crumbs-view-css' => '3840dc4c', 762 762 'phui-document-view-css' => '8be7a5e3', 763 763 'phui-feed-story-css' => 'c9f3a0b5', 764 764 'phui-font-icon-base-css' => '3dad2ae3',
-1
src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
··· 191 191 192 192 $crumbs = $this 193 193 ->buildApplicationCrumbs() 194 - ->setBorder(true) 195 194 ->addTextCrumb($channel->getChannelName(), $uri); 196 195 197 196 $form = id(new AphrontFormView())
-1
src/applications/maniphest/controller/ManiphestReportController.php
··· 52 52 $nav->appendChild($core); 53 53 $nav->setCrumbs( 54 54 $this->buildApplicationCrumbs() 55 - ->setBorder(true) 56 55 ->addTextCrumb(pht('Reports'))); 57 56 58 57 return $this->buildApplicationPage(
-1
src/applications/owners/controller/PhabricatorOwnersListController.php
··· 196 196 197 197 $crumbs = $this->buildApplicationCrumbs(); 198 198 $crumbs->addTextCrumb($header); 199 - $crumbs->setBorder(true); 200 199 201 200 $nav = $this->buildSideNavView(); 202 201 $nav->appendChild($crumbs);
-1
src/applications/search/controller/PhabricatorApplicationSearchController.php
··· 268 268 269 269 $crumbs = $parent 270 270 ->buildApplicationCrumbs() 271 - ->setBorder(true) 272 271 ->addTextCrumb($title); 273 272 274 273 $nav->setCrumbs($crumbs);
+5 -6
src/applications/uiexample/controller/PhabricatorUIExampleRenderController.php
··· 41 41 require_celerity_resource('phabricator-ui-example-css'); 42 42 43 43 $crumbs = $this->buildApplicationCrumbs(); 44 - $crumbs->setBorder(true); 45 44 $crumbs->addTextCrumb($example->getName()); 46 45 47 - $header = id(new PHUIHeaderView()) 48 - ->setHeader(pht('%s (%s)', $example->getName(), get_class($example))) 49 - ->setSubheader($example->getDescription()) 50 - ->setNoBackground(true); 46 + $note = id(new PHUIInfoView()) 47 + ->setTitle(pht('%s (%s)', $example->getName(), get_class($example))) 48 + ->appendChild($example->getDescription()) 49 + ->setSeverity(PHUIInfoView::SEVERITY_NODATA); 51 50 52 51 $nav->appendChild( 53 52 array( 54 53 $crumbs, 55 - $header, 54 + $note, 56 55 $result, 57 56 )); 58 57
+1 -1
src/applications/uiexample/examples/PhabricatorSortTableUIExample.php
··· 89 89 90 90 $panel = new PHUIObjectBoxView(); 91 91 $panel->setHeaderText('Sortable Table of Vehicles'); 92 - $panel->appendChild($table); 92 + $panel->setTable($table); 93 93 94 94 return $panel; 95 95 }
+1 -1
webroot/rsrc/css/application/base/main-menu-view.css
··· 66 66 } 67 67 68 68 .device-desktop .phabricator-main-menu-brand:hover { 69 - background-color: rgba(55,55,55,..08); 69 + background-color: rgba(55,55,55,.08); 70 70 cursor: hand; 71 71 } 72 72
+5 -1
webroot/rsrc/css/phui/phui-crumbs-view.css
··· 80 80 81 81 .device-desktop .phui-crumbs-view a:hover, 82 82 .device-desktop .phui-crumbs-view a:hover .phui-icon-view { 83 - color: {$sky}; 83 + color: {$blue}; 84 84 text-decoration: none; 85 85 } 86 86 ··· 99 99 100 100 .phui-crumb-divider { 101 101 margin: 2px 8px; 102 + } 103 + 104 + .phui-crumbs-view.phui-crumbs-border { 105 + border-bottom: 1px solid {$thinblueborder}; 102 106 } 103 107 104 108 body .phui-crumbs-view + .phui-object-box {