recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Force 'changes' to a string in hunk migration

Summary: Fixes T12090. In obscure situations lost to the mists of time, the `changes` column could be `null`. Force a string cast so the migration finishes, even though these changesets are likely meaningless.

Test Plan:
I did a force-reapply as a sanity check:

```
$ ./bin/storage upgrade -f --apply phabricator:20161213.diff.01.hunks.php
```

That went cleanly; it would only have caught dramatic errors, but I didn't completely butcher things.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12090

Differential Revision: https://secure.phabricator.com/D17168

epriestley 11f3a8cf 6816974d

+2 -1
+2 -1
resources/sql/autopatches/20161213.diff.01.hunks.php
··· 28 28 DifferentialModernHunk::DATATYPE_TEXT, 29 29 'utf8', 30 30 DifferentialModernHunk::DATAFORMAT_RAW, 31 - $row['changes'], 31 + // In rare cases, this could be NULL. See T12090. 32 + (string)$row['changes'], 32 33 $row['dateCreated'], 33 34 $row['dateModified']); 34 35 }