recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix dark mode for line color in Charts

Summary:
Colors of lines and areas in Charts cannot be "fixed" for dark mode by introducing more variables to the Celerity Postprocessor as their colors are not defined via CSS classes but in PHP.

Thus change the dark blue line `rgba(0, 0, 200, 1)` displayed on top of `$lightbluebackground` (`#F8F9FC` in default mode, and problematic `rgba(255,255,255,.05)` in dark mode) to `rgba(41, 128, 185, 1)` which works reasonably well in both default and dark mode.

Refs T15056

Test Plan:
* Enable the "Facts" application at http://phorge.localhost/applications/view/PhabricatorFactApplication/
* Go to http://phorge.localhost/project/reports/1/ and look at the line and its area in the chart

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15056

Differential Revision: https://we.phorge.it/D26237

Andre Klapper 1216f72c 0007de9a

+4 -4
+2 -2
src/applications/project/chart/PhabricatorProjectActivityChartEngine.php
··· 78 78 $function->getFunctionLabel() 79 79 ->setKey('created') 80 80 ->setName(pht('Tasks Created')) 81 - ->setColor('rgba(0, 0, 200, 1)') 82 - ->setFillColor('rgba(0, 0, 200, 0.15)'); 81 + ->setColor('rgba(41, 128, 185, 1)') 82 + ->setFillColor('rgba(41, 128, 185, 0.15)'); 83 83 84 84 $functions[] = $function; 85 85
+2 -2
src/applications/project/chart/PhabricatorProjectBurndownChartEngine.php
··· 73 73 $open_function->getFunctionLabel() 74 74 ->setKey('open') 75 75 ->setName(pht('Open Tasks')) 76 - ->setColor('rgba(0, 0, 200, 1)') 77 - ->setFillColor('rgba(0, 0, 200, 0.15)'); 76 + ->setColor('rgba(41, 128, 185, 1)') 77 + ->setFillColor('rgba(41, 128, 185, 0.15)'); 78 78 79 79 $closed_function->getFunctionLabel() 80 80 ->setKey('closed')