recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue with rendering unit messages for diffs with no buildable

Summary: Fixes T10591. This was accidentally reverted in 148a50e48be146b88036032d1cad772d2627da28, probably when resolvign a merge/rebase.

Test Plan: Will push to production.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10591

Differential Revision: https://secure.phabricator.com/D15474

epriestley 121e68e3 a1dd1ad3

+4
+4
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 1131 1131 DifferentialRevision $revision) { 1132 1132 $viewer = $this->getViewer(); 1133 1133 1134 + if (!$diff->getBuildable()) { 1135 + return null; 1136 + } 1137 + 1134 1138 if (!$diff->getUnitMessages()) { 1135 1139 return null; 1136 1140 }