@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't show description box in Pholio when there isnt one
Summary: n/a
Test Plan: Added title and description to 1 of 2 mocks, toggled left and right, saw correct CSS.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D9580
+26
-23
+17
-17
resources/celerity/map.php
+17
-17
resources/celerity/map.php
···
399
399
'rsrc/js/application/passphrase/phame-credential-control.js' => '1e1c8a59',
400
400
'rsrc/js/application/phame/phame-post-preview.js' => '61d927ec',
401
401
'rsrc/js/application/pholio/behavior-pholio-mock-edit.js' => '1e1e8bb0',
402
-
'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => '7afc17c9',
402
+
'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => '83326068',
403
403
'rsrc/js/application/phortune/behavior-balanced-payment-form.js' => '3b3e1664',
404
404
'rsrc/js/application/phortune/behavior-stripe-payment-form.js' => '1693a296',
405
405
'rsrc/js/application/phortune/behavior-test-payment-form.js' => 'b3e5ee60',
···
624
624
'javelin-behavior-phabricator-watch-anchor' => '06e05112',
625
625
'javelin-behavior-phame-post-preview' => '61d927ec',
626
626
'javelin-behavior-pholio-mock-edit' => '1e1e8bb0',
627
-
'javelin-behavior-pholio-mock-view' => '7afc17c9',
627
+
'javelin-behavior-pholio-mock-view' => '83326068',
628
628
'javelin-behavior-phui-object-box-tabs' => 'a3e2244e',
629
629
'javelin-behavior-phui-timeline-dropdown-menu' => '4d94d9c3',
630
630
'javelin-behavior-policy-control' => 'f3fef818',
···
1372
1372
0 => 'owners-path-editor',
1373
1373
1 => 'javelin-behavior',
1374
1374
),
1375
-
'7afc17c9' =>
1376
-
array(
1377
-
0 => 'javelin-behavior',
1378
-
1 => 'javelin-util',
1379
-
2 => 'javelin-stratcom',
1380
-
3 => 'javelin-dom',
1381
-
4 => 'javelin-vector',
1382
-
5 => 'javelin-magical-init',
1383
-
6 => 'javelin-request',
1384
-
7 => 'javelin-history',
1385
-
8 => 'javelin-workflow',
1386
-
9 => 'javelin-mask',
1387
-
10 => 'javelin-behavior-device',
1388
-
11 => 'phabricator-keyboard-shortcut',
1389
-
),
1390
1375
'7ba325ee' =>
1391
1376
array(
1392
1377
0 => 'javelin-install',
···
2126
2111
0 => 'javelin-behavior',
2127
2112
1 => 'javelin-dom',
2128
2113
2 => 'javelin-workflow',
2114
+
),
2115
+
83326068 =>
2116
+
array(
2117
+
0 => 'javelin-behavior',
2118
+
1 => 'javelin-util',
2119
+
2 => 'javelin-stratcom',
2120
+
3 => 'javelin-dom',
2121
+
4 => 'javelin-vector',
2122
+
5 => 'javelin-magical-init',
2123
+
6 => 'javelin-request',
2124
+
7 => 'javelin-history',
2125
+
8 => 'javelin-workflow',
2126
+
9 => 'javelin-mask',
2127
+
10 => 'javelin-behavior-device',
2128
+
11 => 'phabricator-keyboard-shortcut',
2129
2129
),
2130
2130
),
2131
2131
'packages' =>
+9
-6
webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js
+9
-6
webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js
···
656
656
}
657
657
info = JX.$N('div', {className: 'pholio-image-info'}, info);
658
658
659
-
var desc = JX.$N(
660
-
'div',
661
-
{className: 'pholio-image-description'},
662
-
JX.$H(image.descriptionMarkup));
663
-
664
-
return [buttons, info, desc];
659
+
if (image.descriptionMarkup === '') {
660
+
return [buttons, info];
661
+
} else {
662
+
var desc = JX.$N(
663
+
'div',
664
+
{className: 'pholio-image-description'},
665
+
JX.$H(image.descriptionMarkup));
666
+
return [buttons, info, desc];
667
+
}
665
668
}
666
669
667
670
function render_reticle(classes) {