@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
PHPDoc: Replace non-existing param type id with int
Summary: `id` is not a valid type. See https://docs.phpdoc.org/guide/references/phpdoc/types.html.
Test Plan: Read docs; run static code analysis.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D26075
+2
-2
+1
-1
src/applications/differential/parser/DifferentialChangesetParser.php
+1
-1
src/applications/differential/parser/DifferentialChangesetParser.php
···
240
240
* the left and right halves of the displayed diff to be correctly mapped to
241
241
* storage changesets.
242
242
*
243
-
* @param id $id The Differential Changeset ID that comments added to the
243
+
* @param int $id The Differential Changeset ID that comments added to the
244
244
* right side of the visible diff should be attached to.
245
245
* @param bool $is_new If true, attach new comments to the right side of the
246
246
* storage changeset. Note that this may be false, if the left
+1
-1
src/infrastructure/daemon/workers/PhabricatorWorker.php
+1
-1
src/infrastructure/daemon/workers/PhabricatorWorker.php
···
287
287
* This method does not provide any assurances about when these tasks will
288
288
* execute, or even guarantee that it will have any effect at all.
289
289
*
290
-
* @param list<id> $ids List of task IDs to try to awaken.
290
+
* @param array<int> $ids List of task IDs to try to awaken.
291
291
* @return void
292
292
*/
293
293
final public static function awakenTaskIDs(array $ids) {