@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Diffusion - fix first "old ref" in push log
Summary: This is a fake hash of many 0s which ends up being a bad link. Detect the fake hash and don't print a link. Fixes T6826.
Test Plan: looked at push log and no longer saw a many 0 entry for the first old ref.
Reviewers: epriestley, chad
Reviewed By: chad
Subscribers: Korvin, epriestley
Maniphest Tasks: T6826
Differential Revision: https://secure.phabricator.com/D11096
+10
-6
+10
-6
src/applications/diffusion/view/DiffusionPushLogListView.php
+10
-6
src/applications/diffusion/view/DiffusionPushLogListView.php
···
52
52
$event_id = $log->getPushEvent()->getID();
53
53
54
54
$callsign = $log->getRepository()->getCallsign();
55
+
$old_ref_link = null;
56
+
if ($log->getRefOld() != DiffusionCommitHookEngine::EMPTY_HASH) {
57
+
$old_ref_link = phutil_tag(
58
+
'a',
59
+
array(
60
+
'href' => '/r'.$callsign.$log->getRefOld(),
61
+
),
62
+
$log->getRefOldShort());
63
+
}
55
64
$rows[] = array(
56
65
phutil_tag(
57
66
'a',
···
70
79
$log->getPushEvent()->getRemoteProtocol(),
71
80
$log->getRefType(),
72
81
$log->getRefName(),
73
-
phutil_tag(
74
-
'a',
75
-
array(
76
-
'href' => '/r'.$callsign.$log->getRefOld(),
77
-
),
78
-
$log->getRefOldShort()),
82
+
$old_ref_link,
79
83
phutil_tag(
80
84
'a',
81
85
array(