@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Smooth "no effect" detection in Maniphest for @mentions
Summary:
Ref T2217. Since we aren't actually using subscriptions yet, the "transactions have no effect" detection can trigger for `@mention`s of users who are already CC'd on a task.
Be more conservative about generating a CC transaction.
Test Plan: See screenshot.
Reviewers: btrahan, chad
Reviewed By: chad
CC: chad, aran
Maniphest Tasks: T2217
Differential Revision: https://secure.phabricator.com/D7095
+5
-3
+5
-3
src/applications/maniphest/controller/ManiphestTransactionSaveController.php
+5
-3
src/applications/maniphest/controller/ManiphestTransactionSaveController.php
···
197
197
}
198
198
}
199
199
200
+
// Evade no-effect detection in the new editor stuff until we can switch
201
+
// to subscriptions.
202
+
$added_ccs = array_diff($added_ccs, $task->getCCPHIDs());
203
+
200
204
if ($added_ccs || $force_cc_transaction) {
201
-
// We've added CCs, so include a CC transaction. It's safe to do this even
202
-
// if we're just "adding" CCs which already exist, because the
203
-
// ManiphestTransactionEditor is smart enough to ignore them.
205
+
// We've added CCs, so include a CC transaction.
204
206
$all_ccs = array_merge($task->getCCPHIDs(), $added_ccs);
205
207
$cc_transaction->setNewValue($all_ccs);
206
208
$transactions[] = $cc_transaction;