@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up inline edit ui
Summary: Fixes the button spacing issue (doesn't seem related to forms?) and moves fonts and sizes over to Helvetica.
Test Plan: Submit many inline comments.
Reviewers: epriestley, btrahan
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5882
+28
-28
+16
-16
src/__celerity_resource_map__.php
+16
-16
src/__celerity_resource_map__.php
···
949
949
),
950
950
'differential-changeset-view-css' =>
951
951
array(
952
-
'uri' => '/res/ea694162/rsrc/css/application/differential/changeset-view.css',
952
+
'uri' => '/res/8ee213f4/rsrc/css/application/differential/changeset-view.css',
953
953
'type' => 'css',
954
954
'requires' =>
955
955
array(
···
4111
4111
'uri' => '/res/pkg/4ccfeb47/darkconsole.pkg.js',
4112
4112
'type' => 'js',
4113
4113
),
4114
-
'19d2a41f' =>
4114
+
'dd27a69b' =>
4115
4115
array(
4116
4116
'name' => 'differential.pkg.css',
4117
4117
'symbols' =>
···
4130
4130
11 => 'differential-local-commits-view-css',
4131
4131
12 => 'inline-comment-summary-css',
4132
4132
),
4133
-
'uri' => '/res/pkg/19d2a41f/differential.pkg.css',
4133
+
'uri' => '/res/pkg/dd27a69b/differential.pkg.css',
4134
4134
'type' => 'css',
4135
4135
),
4136
4136
'27c55b30' =>
···
4254
4254
'aphront-tokenizer-control-css' => '56e0b740',
4255
4255
'aphront-tooltip-css' => '56e0b740',
4256
4256
'aphront-typeahead-control-css' => '56e0b740',
4257
-
'differential-changeset-view-css' => '19d2a41f',
4258
-
'differential-core-view-css' => '19d2a41f',
4257
+
'differential-changeset-view-css' => 'dd27a69b',
4258
+
'differential-core-view-css' => 'dd27a69b',
4259
4259
'differential-inline-comment-editor' => '27c55b30',
4260
-
'differential-local-commits-view-css' => '19d2a41f',
4261
-
'differential-results-table-css' => '19d2a41f',
4262
-
'differential-revision-add-comment-css' => '19d2a41f',
4263
-
'differential-revision-comment-css' => '19d2a41f',
4264
-
'differential-revision-comment-list-css' => '19d2a41f',
4265
-
'differential-revision-history-css' => '19d2a41f',
4266
-
'differential-revision-list-css' => '19d2a41f',
4267
-
'differential-table-of-contents-css' => '19d2a41f',
4260
+
'differential-local-commits-view-css' => 'dd27a69b',
4261
+
'differential-results-table-css' => 'dd27a69b',
4262
+
'differential-revision-add-comment-css' => 'dd27a69b',
4263
+
'differential-revision-comment-css' => 'dd27a69b',
4264
+
'differential-revision-comment-list-css' => 'dd27a69b',
4265
+
'differential-revision-history-css' => 'dd27a69b',
4266
+
'differential-revision-list-css' => 'dd27a69b',
4267
+
'differential-table-of-contents-css' => 'dd27a69b',
4268
4268
'diffusion-commit-view-css' => 'c8ce2d88',
4269
4269
'diffusion-icons-css' => 'c8ce2d88',
4270
4270
'global-drag-and-drop-css' => '56e0b740',
4271
-
'inline-comment-summary-css' => '19d2a41f',
4271
+
'inline-comment-summary-css' => 'dd27a69b',
4272
4272
'javelin-aphlict' => '26980a1c',
4273
4273
'javelin-behavior' => '7d174323',
4274
4274
'javelin-behavior-aphlict-dropdown' => '26980a1c',
···
4343
4343
'maniphest-task-summary-css' => '6b1fccc6',
4344
4344
'maniphest-transaction-detail-css' => '6b1fccc6',
4345
4345
'phabricator-busy' => '26980a1c',
4346
-
'phabricator-content-source-view-css' => '19d2a41f',
4346
+
'phabricator-content-source-view-css' => 'dd27a69b',
4347
4347
'phabricator-core-buttons-css' => '56e0b740',
4348
4348
'phabricator-core-css' => '56e0b740',
4349
4349
'phabricator-crumbs-view-css' => '56e0b740',
···
4365
4365
'phabricator-notification-css' => '56e0b740',
4366
4366
'phabricator-notification-menu-css' => '56e0b740',
4367
4367
'phabricator-object-item-list-view-css' => '56e0b740',
4368
-
'phabricator-object-selector-css' => '19d2a41f',
4368
+
'phabricator-object-selector-css' => 'dd27a69b',
4369
4369
'phabricator-phtize' => '26980a1c',
4370
4370
'phabricator-prefab' => '26980a1c',
4371
4371
'phabricator-project-tag-css' => '6b1fccc6',
+1
-1
src/applications/differential/view/DifferentialInlineCommentEditView.php
+1
-1
src/applications/differential/view/DifferentialInlineCommentEditView.php
+11
-11
webroot/rsrc/css/application/differential/changeset-view.css
+11
-11
webroot/rsrc/css/application/differential/changeset-view.css
···
174
174
175
175
.differential-diff td.show-more,
176
176
.differential-diff td.differential-shield {
177
-
font-family: "Verdana";
178
-
font-size: 11px;
177
+
font-family: "Helvetica Neue", "Arial", sans-serif;
178
+
font-size: 12px;
179
179
white-space: normal;
180
180
}
181
181
···
211
211
.differential-meta-notice {
212
212
border: 1px solid #ffdd99;
213
213
background: #ffeeaa;
214
-
font-family: "Verdana";
215
-
font-size: 11px;
214
+
font-family: "Helvetica Neue", "Arial", sans-serif;
215
+
font-size: 12px;
216
216
padding: 1em;
217
217
margin: 0 0 6px 0;
218
218
}
···
236
236
.differential-inline-comment-edit {
237
237
background: #f9f9f1;
238
238
border: 1px solid #aaaa88;
239
-
font-family: Verdana;
240
-
font-size: 11px;
239
+
font-family: "Helvetica Neue", "Arial", sans-serif;
240
+
font-size: 12px;
241
241
margin: 6px 0px;
242
242
padding: 8px 10px;
243
243
width: 100%;
···
290
290
291
291
292
292
.differential-inline-comment-edit-textarea {
293
-
width: 99%;
293
+
width: 100%;
294
294
height: 12em;
295
295
}
296
296
···
355
355
text-align: center;
356
356
background: #ffeeaa;
357
357
margin: 3px 0 1px;
358
-
font: 11px "Verdana";
358
+
font: 12px;
359
359
color: 444444;
360
360
}
361
361
···
364
364
}
365
365
366
366
.differential-inline-comment-edit {
367
-
padding: 8px 18px 8px 12px;
367
+
padding: 10px;
368
368
}
369
369
370
370
.differential-inline-comment-edit-buttons {
371
-
padding: 2px 0px;
371
+
padding: 5px 0 0 0;
372
+
372
373
}
373
374
374
375
.differential-inline-comment-edit-buttons button {
···
379
380
.differential-inline-comment-edit-title {
380
381
font-weight: bold;
381
382
color: #333333;
382
-
border-bottom: 1px solid #ccccaa;
383
383
padding-bottom: 2px;
384
384
margin-bottom: 6px;
385
385
}