-4

scripts/daemon/launch_daemon.php

reviewed

··· 1 1 #!/usr/bin/env php 2 2 <?php 3 3 4 4 - // NOTE: This is substantially the same as the libphutil/ "launch_daemon.php" 5 5 - // script, except it loads the Phabricator environment and adds some Phabricator 6 6 - // specific flags. 7 7 - 8 4 if (function_exists('pcntl_async_signals')) { 9 5 pcntl_async_signals(true); 10 6 } else {

+2 -2

src/docs/contributor/adding_new_classes.diviner

reviewed

··· 112 112 The directory '/some/path/libcustom/src' does not exist. 113 113 114 114 Do you want to create it? [y/N] y 115 115 - Creating new libphutil library in '/some/path/libcustom/src'. 115 115 + Creating new library in '/some/path/libcustom/src'. 116 116 Choose a name for the new library. 117 117 118 118 What do you want to name this library? ··· 138 138 any time. If you check your library into version control, you can add this 139 139 file to ignore rules (like `.gitignore`). 140 140 - `src/__phutil_library_init__.php` This records the name of the library and 141 141 - tells libphutil that a library exists here. 141 141 + tells Arcanist that a library exists here. 142 142 - `src/__phutil_library_map__.php` This is a map of all the symbols 143 143 (functions and classes) in the library, which allows them to be autoloaded 144 144 at runtime and dependencies to be statically managed by `arc liberate`.

+1 -1

src/docs/contributor/unit_tests.diviner

reviewed

··· 7 7 8 8 Arcanist and Phorge provide and use a simple unit test framework. This 9 9 document is aimed at project contributors and describes how to use it to add 10 10 - and run tests in these projects or other libphutil libraries. 10 10 + and run tests in these projects or other custom libraries. 11 11 12 12 In the general case, you can integrate `arc` with a custom unit test engine 13 13 (like PHPUnit or any other unit testing library) to run tests in other projects.

+3 -3

src/docs/flavor/php_pitfalls.diviner

reviewed

··· 18 18 intermediate arrays and copies every element it has previously seen each time 19 19 you iterate. 20 20 21 21 - In a libphutil environment, you can use @{function@arcanist:array_mergev} 21 21 + In an Arcanist environment, you can use @{function@arcanist:array_mergev} 22 22 instead. 23 23 24 24 = `var_export()` Hates Baby Animals = ··· 193 193 (e.g., `sort()`, `asort()`, `ksort()`, or `natcasesort()`). Sort this array 194 194 instead, and use it to reorder the original array. 195 195 196 196 - In a libphutil environment, you can often do this easily with 196 196 + In an Arcanist environment, you can often do this easily with 197 197 @{function@arcanist:isort} or @{function@arcanist:msort}. 198 198 199 199 = `array_intersect()` and `array_diff()` are Also Slow = ··· 316 316 ``` 317 317 318 318 ...you'll probably invent a very interesting, very novel solution that is very 319 319 - wrong. In a libphutil environment, solve this problem with 319 319 + wrong. In an Arcanist environment, solve this problem with 320 320 @{function@arcanist:newv}. Elsewhere, copy `newv()`'s implementation. 321 321 322 322 = Equality is not Transitive =

+1 -1

src/docs/user/userguide/arcanist.diviner

reviewed

··· 64 64 Arcanist has some advanced features as well, you can: 65 65 66 66 - execute Conduit method calls with `arc call-conduit` 67 67 - - create or update libphutil libraries with `arc liberate` 67 67 + - create or update libraries with `arc liberate` 68 68 - activate tab completion with `arc shell-complete` 69 69 - ...or extend Arcanist and add new commands. 70 70

+1 -1

src/docs/user/userguide/arcanist_lint_unit.diviner

reviewed

··· 34 34 - add the class name to your `.arcconfig` as the **lint.engine**, 35 35 **unit.engine**, or **arcanist_configuration**. 36 36 37 37 - = Create a libphutil Library = 37 37 + = Create a Library = 38 38 39 39 If you haven't created a library for the class to live in yet, you need to do 40 40 that first. Follow the instructions in

+1 -1

src/docs/user/userguide/arcanist_new_project.diviner

reviewed

··· 48 48 - **load**: list of additional Phutil libraries to load at startup. 49 49 See below for details about path resolution, or see 50 50 @{article@contrib:Adding New Classes} for a general introduction to 51 51 - libphutil libraries. 51 51 + libraries. 52 52 - **https.cabundle**: specifies the path to an alternate certificate bundle 53 53 for use when making HTTPS connections. 54 54 - **lint.engine**: the name of a subclass of

+4 -4

src/docs/user/userguide/events.diviner

reviewed

··· 24 24 To install event listeners in Phorge, follow these steps: 25 25 26 26 - Write a listener class which extends @{class@arcanist:PhutilEventListener}. 27 27 - - Add it to a libphutil library, or create a new library (for instructions, 27 27 + - Add it to a library, or create a new library (for instructions, 28 28 see @{article@contrib:Adding New Classes}. 29 29 - Configure Phorge to load the library by adding it to `load-libraries` 30 30 in the Phorge config. ··· 41 41 To install event listeners in Arcanist, follow these steps: 42 42 43 43 - Write a listener class which extends @{class@arcanist:PhutilEventListener}. 44 44 - - Add it to a libphutil library, or create a new library (for instructions, 44 44 + - Add it to a library, or create a new library (for instructions, 45 45 see @{article@contrib:Adding New Classes}. 46 46 - Configure Phorge to load the library by adding it to `load` 47 47 in the Arcanist config (e.g., `.arcconfig`, or user/global config). ··· 185 185 If you're having problems with your listener, try these steps: 186 186 187 187 - If you're getting an error about Phorge being unable to find the 188 188 - listener class, make sure you've added it to a libphutil library and 189 189 - configured Phorge to load the library with `load-libraries`. 188 188 + listener class, make sure you've added it to a library and configured 189 189 + Phorge to load the library with `load-libraries`. 190 190 - Make sure the listener is registered. It should appear in the "Events" tab 191 191 of DarkConsole. If it's not there, you may have forgotten to add it to 192 192 `events.listeners`.

+1 -1

src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php

reviewed

··· 49 49 if (!$libraries) { 50 50 throw new PhutilArgumentUsageException( 51 51 pht( 52 52 - 'Path "%s" contains no libphutil libraries.', 52 52 + 'Path "%s" contains no libraries.', 53 53 $path)); 54 54 } 55 55