@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Convert people manage page to two column
Summary: Ref T10545, this brings flags back? and converts the layout to two column w/curtain
Test Plan: View a few manage pages.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T10545
Differential Revision: https://secure.phabricator.com/D15449
+26
-23
+26
-22
src/applications/people/controller/PhabricatorPeopleProfileManageController.php
+26
-22
src/applications/people/controller/PhabricatorPeopleProfileManageController.php
···
35
35
$header = id(new PHUIHeaderView())
36
36
->setHeader($user->getFullName())
37
37
->setSubheader(array($profile_icon, $profile_title))
38
-
->setImage($picture);
38
+
->setImage($picture)
39
+
->setProfileHeader(true);
39
40
40
-
$actions = $this->buildActionList($user);
41
+
$curtain = $this->buildCurtain($user);
41
42
$properties = $this->buildPropertyView($user);
42
-
$properties->setActionList($actions);
43
43
$name = $user->getUsername();
44
-
45
-
$object_box = id(new PHUIObjectBoxView())
46
-
->setHeader($header)
47
-
->addPropertyList($properties);
48
44
49
45
$nav = $this->getProfileMenu();
50
46
$nav->selectFilter(PhabricatorPeopleProfilePanelEngine::PANEL_MANAGE);
···
56
52
57
53
$crumbs = $this->buildApplicationCrumbs();
58
54
$crumbs->addTextCrumb(pht('Manage'));
55
+
$crumbs->setBorder(true);
56
+
57
+
$manage = id(new PHUITwoColumnView())
58
+
->setHeader($header)
59
+
->setCurtain($curtain)
60
+
->addPropertySection(pht('DETAILS'), $properties)
61
+
->setMainColumn(
62
+
array(
63
+
$timeline,
64
+
));
59
65
60
66
return $this->newPage()
61
67
->setTitle(
···
67
73
->setCrumbs($crumbs)
68
74
->appendChild(
69
75
array(
70
-
$object_box,
71
-
$timeline,
76
+
$manage,
72
77
));
73
78
}
74
79
···
87
92
return $view;
88
93
}
89
94
90
-
private function buildActionList(PhabricatorUser $user) {
95
+
private function buildCurtain(PhabricatorUser $user) {
91
96
$viewer = $this->getViewer();
92
-
93
-
$actions = id(new PhabricatorActionListView())
94
-
->setUser($viewer);
95
97
96
98
$can_edit = PhabricatorPolicyFilter::hasCapability(
97
99
$viewer,
98
100
$user,
99
101
PhabricatorPolicyCapability::CAN_EDIT);
100
102
101
-
$actions->addAction(
103
+
$curtain = $this->newCurtainView($user);
104
+
105
+
$curtain->addAction(
102
106
id(new PhabricatorActionView())
103
107
->setIcon('fa-pencil')
104
108
->setName(pht('Edit Profile'))
···
106
110
->setDisabled(!$can_edit)
107
111
->setWorkflow(!$can_edit));
108
112
109
-
$actions->addAction(
113
+
$curtain->addAction(
110
114
id(new PhabricatorActionView())
111
115
->setIcon('fa-picture-o')
112
116
->setName(pht('Edit Profile Picture'))
···
114
118
->setDisabled(!$can_edit)
115
119
->setWorkflow(!$can_edit));
116
120
117
-
$actions->addAction(
121
+
$curtain->addAction(
118
122
id(new PhabricatorActionView())
119
123
->setIcon('fa-wrench')
120
124
->setName(pht('Edit Settings'))
···
134
138
$is_self = ($user->getPHID() === $viewer->getPHID());
135
139
$can_admin = ($is_admin && !$is_self);
136
140
137
-
$actions->addAction(
141
+
$curtain->addAction(
138
142
id(new PhabricatorActionView())
139
143
->setIcon($empower_icon)
140
144
->setName($empower_name)
···
142
146
->setWorkflow(true)
143
147
->setHref($this->getApplicationURI('empower/'.$user->getID().'/')));
144
148
145
-
$actions->addAction(
149
+
$curtain->addAction(
146
150
id(new PhabricatorActionView())
147
151
->setIcon('fa-tag')
148
152
->setName(pht('Change Username'))
···
158
162
$disable_name = pht('Disable User');
159
163
}
160
164
161
-
$actions->addAction(
165
+
$curtain->addAction(
162
166
id(new PhabricatorActionView())
163
167
->setIcon($disable_icon)
164
168
->setName($disable_name)
···
166
170
->setWorkflow(true)
167
171
->setHref($this->getApplicationURI('disable/'.$user->getID().'/')));
168
172
169
-
$actions->addAction(
173
+
$curtain->addAction(
170
174
id(new PhabricatorActionView())
171
175
->setIcon('fa-times')
172
176
->setName(pht('Delete User'))
···
176
180
177
181
$can_welcome = ($is_admin && $user->canEstablishWebSessions());
178
182
179
-
$actions->addAction(
183
+
$curtain->addAction(
180
184
id(new PhabricatorActionView())
181
185
->setIcon('fa-envelope')
182
186
->setName(pht('Send Welcome Email'))
···
184
188
->setDisabled(!$can_welcome)
185
189
->setHref($this->getApplicationURI('welcome/'.$user->getID().'/')));
186
190
187
-
return $actions;
191
+
return $curtain;
188
192
}
189
193
190
194