recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PhutilRemarkupEngineTestCase when run alone

Summary:
(Technical explanation: the `PhabricatorTestCase` class includes extra code to setup the Phabricator config system. Originally remarkup was part of the libphutil repo and didn't depend on any Phab stuff. Phorge broke this rule that had no reason to exist anymore T15161, but didn't update the test, resulting in this extremely silly edge case ...)

Fixes T15973 (and sorry @valerio.bozzolan for stealing a ticket from you for the third time in the last few days)

Test Plan: Run `arc unit src/infrastructure/markup/__tests__/PhutilRemarkupEngineTestCase.php`

Reviewers: O1 Blessed Committers, aklapper, valerio.bozzolan

Reviewed By: O1 Blessed Committers, aklapper, valerio.bozzolan

Subscribers: aklapper, tobiaswiese, Matthew, valerio.bozzolan, Cigaryno

Maniphest Tasks: T15973

Differential Revision: https://we.phorge.it/D26662

Pppery 13950b63 25344426

+2 -2
+1 -1
src/__phutil_library_map__.php
··· 12700 12700 'PhutilRemarkupDelRule' => 'PhutilRemarkupRule', 12701 12701 'PhutilRemarkupDocumentLinkRule' => 'PhutilRemarkupRule', 12702 12702 'PhutilRemarkupEngine' => 'PhutilMarkupEngine', 12703 - 'PhutilRemarkupEngineTestCase' => 'PhutilTestCase', 12703 + 'PhutilRemarkupEngineTestCase' => 'PhabricatorTestCase', 12704 12704 'PhutilRemarkupEscapeRemarkupRule' => 'PhutilRemarkupRule', 12705 12705 'PhutilRemarkupEvalRule' => 'PhutilRemarkupRule', 12706 12706 'PhutilRemarkupHeaderBlockRule' => 'PhutilRemarkupBlockRule',
+1 -1
src/infrastructure/markup/__tests__/PhutilRemarkupEngineTestCase.php
··· 3 3 /** 4 4 * Test cases for @{class:PhutilRemarkupEngine}. 5 5 */ 6 - final class PhutilRemarkupEngineTestCase extends PhutilTestCase { 6 + final class PhutilRemarkupEngineTestCase extends PhabricatorTestCase { 7 7 8 8 public function testEngine() { 9 9 $root = dirname(__FILE__).'/remarkup/';