@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When a worker task fails permanently, log the reason
Summary: Ref T6238. This makes debugging permanent task failures easier (we log reasoning for temporary failures already, just not permanent ones).
Test Plan: Saw more useful permanent failure log.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T6238
Differential Revision: https://secure.phabricator.com/D10945
+5
-1
+5
-1
src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php
+5
-1
src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php
···
20
20
$ex = $task->getExecutionException();
21
21
if ($ex) {
22
22
if ($ex instanceof PhabricatorWorkerPermanentFailureException) {
23
-
$this->log("Task {$id} failed permanently.");
23
+
$this->log(
24
+
pht(
25
+
'Task %s failed permanently: %s',
26
+
$id,
27
+
$ex->getMessage()));
24
28
} else if ($ex instanceof PhabricatorWorkerYieldException) {
25
29
$this->log(pht('Task %s yielded.', $id));
26
30
} else {