@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix project view and edit uris on creation
Summary: Fixes T6305, sets edit and view uris later in the stack.
Test Plan: Create and edit a project in /project/. Create a project in a dialog. Get redirected to correct place. Verify Cancel send you back to home.
Reviewers: epriestley, btrahan
Reviewed By: btrahan
Subscribers: Korvin, epriestley
Maniphest Tasks: T6305
Differential Revision: https://secure.phabricator.com/D10702
+9
-8
+9
-8
src/applications/project/controller/PhabricatorProjectEditDetailsController.php
+9
-8
src/applications/project/controller/PhabricatorProjectEditDetailsController.php
···
46
46
->setViewer($viewer)
47
47
->readFieldsFromStorage($project);
48
48
49
-
$view_uri = $this->getApplicationURI('view/'.$project->getID().'/');
50
-
$edit_uri = $this->getApplicationURI('edit/'.$project->getID().'/');
51
-
52
49
$e_name = true;
53
50
$e_slugs = false;
54
51
$e_edit = null;
···
151
148
}
152
149
153
150
if ($is_new) {
154
-
$redirect_uri = $view_uri;
151
+
$redirect_uri =
152
+
$this->getApplicationURI('view/'.$project->getID().'/');
155
153
} else {
156
-
$redirect_uri = $edit_uri;
154
+
$redirect_uri =
155
+
$this->getApplicationURI('edit/'.$project->getID().'/');
157
156
}
158
157
159
158
return id(new AphrontRedirectResponse())->setURI($redirect_uri);
···
288
287
289
288
$form->appendChild(
290
289
id(new AphrontFormSubmitControl())
291
-
->addCancelButton($edit_uri)
290
+
->addCancelButton($this->getApplicationURI())
292
291
->setValue(pht('Save')));
293
292
294
293
$form_box = id(new PHUIObjectBoxView())
···
301
300
$crumbs->addTextCrumb($title);
302
301
} else {
303
302
$crumbs
304
-
->addTextCrumb($project->getName(), $view_uri)
305
-
->addTextCrumb(pht('Edit'), $edit_uri)
303
+
->addTextCrumb($project->getName(),
304
+
$this->getApplicationURI('view/'.$project->getID().'/'))
305
+
->addTextCrumb(pht('Edit'),
306
+
$this->getApplicationURI('edit/'.$project->getID().'/'))
306
307
->addTextCrumb(pht('Details'));
307
308
}
308
309