@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Force a couple of Conduit results to the proper types in Calendar
Summary:
Ref T11706. Add some casts so we don't return `"0"` for `false`.
Also I forgot to document one of the things.
Test Plan: Called `calendar.event.search`.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11706
Differential Revision: https://secure.phabricator.com/D16690
+6
-2
+6
-2
src/applications/calendar/storage/PhabricatorCalendarEvent.php
+6
-2
src/applications/calendar/storage/PhabricatorCalendarEvent.php
···
1057
1057
->setType('string')
1058
1058
->setDescription(pht('The event description.')),
1059
1059
id(new PhabricatorConduitSearchFieldSpecification())
1060
+
->setKey('isAllDay')
1061
+
->setType('bool')
1062
+
->setDescription(pht('True if the event is an all day event.')),
1063
+
id(new PhabricatorConduitSearchFieldSpecification())
1060
1064
->setKey('startDateTime')
1061
1065
->setType('datetime')
1062
1066
->setDescription(pht('Start date and time of the event.')),
···
1074
1078
return array(
1075
1079
'name' => $this->getName(),
1076
1080
'description' => $this->getDescription(),
1077
-
'isAllDay' => $this->getIsAllDay(),
1081
+
'isAllDay' => (bool)$this->getIsAllDay(),
1078
1082
'startDateTime' => $this->getConduitDateTime($start_datetime),
1079
1083
'endDateTime' => $this->getConduitDateTime($end_datetime),
1080
1084
);
···
1097
1101
->overrideTimezoneIdentifier($this->viewerTimezone);
1098
1102
1099
1103
return array(
1100
-
'epoch' => $epoch,
1104
+
'epoch' => (int)$epoch,
1101
1105
'display' => array(
1102
1106
'default' => phabricator_datetime($epoch, $viewer),
1103
1107
),