@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add Spaces to Projects
Summary:
See PHI774. Ref T13164. There is no reason projects //don't// support Spaces, just a vague concern that it's not hugely useful and might be a bit confusing.
However, it's at least somewhat useful (to improve consistency and reduce special casing) and doesn't necessarily seem more confusing than Projects are anyway. Support is trivial from a technical point of view, so just hook it up.
Test Plan: Created new projects, shifted projects between spaces. The support is all pretty much automatic.
Reviewers: amckinley
Reviewed By: amckinley
Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam
Maniphest Tasks: T13164
Differential Revision: https://secure.phabricator.com/D19549
+15
-1
+2
resources/sql/autopatches/20180730.project.01.spaces.sql
+2
resources/sql/autopatches/20180730.project.01.spaces.sql
+1
src/__phutil_library_map__.php
+1
src/__phutil_library_map__.php
···
9752
9752
'PhabricatorFerretInterface',
9753
9753
'PhabricatorConduitResultInterface',
9754
9754
'PhabricatorColumnProxyInterface',
9755
+
'PhabricatorSpacesInterface',
9755
9756
),
9756
9757
'PhabricatorProjectAddHeraldAction' => 'PhabricatorProjectHeraldAction',
9757
9758
'PhabricatorProjectApplication' => 'PhabricatorApplication',
+12
-1
src/applications/project/storage/PhabricatorProject.php
+12
-1
src/applications/project/storage/PhabricatorProject.php
···
11
11
PhabricatorFulltextInterface,
12
12
PhabricatorFerretInterface,
13
13
PhabricatorConduitResultInterface,
14
-
PhabricatorColumnProxyInterface {
14
+
PhabricatorColumnProxyInterface,
15
+
PhabricatorSpacesInterface {
15
16
16
17
protected $name;
17
18
protected $status = PhabricatorProjectStatus::STATUS_ACTIVE;
···
38
39
protected $projectPathKey;
39
40
40
41
protected $properties = array();
42
+
protected $spacePHID;
41
43
42
44
private $memberPHIDs = self::ATTACHABLE;
43
45
private $watcherPHIDs = self::ATTACHABLE;
···
82
84
->setViewPolicy($view_policy)
83
85
->setEditPolicy($edit_policy)
84
86
->setJoinPolicy($join_policy)
87
+
->setSpacePHID($actor->getDefaultSpacePHID())
85
88
->setIsMembershipLocked(0)
86
89
->attachMemberPHIDs(array())
87
90
->attachSlugs(array())
···
694
697
AphrontRequest $request) {
695
698
696
699
return $timeline;
700
+
}
701
+
702
+
703
+
/* -( PhabricatorSpacesInterface )----------------------------------------- */
704
+
705
+
706
+
public function getSpacePHID() {
707
+
return $this->spacePHID;
697
708
}
698
709
699
710