@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Give MFA gates a more consistent UI
Summary: Depends on D20057. Currently, we show an "MFA" message on one of these and an "Error" message on the other, with different icons and colors. Use "MFA" for both, with the MFA icon / color.
Test Plan: Hit both varations, saw more consistency.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20059
+13
-9
+13
-9
src/aphront/handler/PhabricatorHighSecurityRequestExceptionHandler.php
+13
-9
src/aphront/handler/PhabricatorHighSecurityRequestExceptionHandler.php
···
78
78
$form_layout = $form->buildLayoutView();
79
79
80
80
if ($is_upgrade) {
81
-
$messages = array(
82
-
pht(
83
-
'You are taking an action which requires you to enter '.
84
-
'high security.'),
85
-
);
81
+
$message = pht(
82
+
'You are taking an action which requires you to enter '.
83
+
'high security.');
86
84
87
85
$info_view = id(new PHUIInfoView())
88
86
->setSeverity(PHUIInfoView::SEVERITY_MFA)
89
-
->setErrors($messages);
87
+
->setErrors(array($message));
90
88
91
89
$dialog
92
90
->appendChild($info_view)
···
100
98
'period of time. When you are finished taking sensitive '.
101
99
'actions, you should leave high security.'));
102
100
} else {
101
+
$message = pht(
102
+
'You are taking an action which requires you to provide '.
103
+
'multi-factor credentials.');
104
+
105
+
$info_view = id(new PHUIInfoView())
106
+
->setSeverity(PHUIInfoView::SEVERITY_MFA)
107
+
->setErrors(array($message));
108
+
103
109
$dialog
110
+
->appendChild($info_view)
104
111
->setErrors(
105
112
array(
106
-
pht(
107
-
'You are taking an action which requires you to provide '.
108
-
'multi-factor credentials.'),
109
113
))
110
114
->appendChild($form_layout);
111
115
}